Bug 72669 - [chromium] Disable incremental uploading in threaded compositing path
Summary: [chromium] Disable incremental uploading in threaded compositing path
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-17 15:15 PST by James Robinson
Modified: 2011-11-17 20:09 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.91 KB, patch)
2011-11-17 15:16 PST, James Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2011-11-17 15:15:11 PST 
[chromium] Disable incremental uploading in threaded compositing path
Comment 1 James Robinson 2011-11-17 15:16:38 PST 
Created attachment 115696 [details]
Patch
Comment 2 Nat Duca 2011-11-17 15:20:57 PST 
Comment on attachment 115696 [details]
Patch

LGTM but lets get someone working on fixing this. When the prerenderer patch lands, we're gonna need this I fear.
Comment 3 Adrienne Walker 2011-11-17 15:23:30 PST 
Comment on attachment 115696 [details]
Patch

Looks good to me.  I had intended this to be something we could play with for performance, and disabling it until we can make it correct seems like the right choice.
Comment 4 Kenneth Russell 2011-11-17 15:25:20 PST 
Comment on attachment 115696 [details]
Patch

rs=me
Comment 5 Shawn Singh 2011-11-17 15:26:56 PST 
(In reply to comment #2)
> (From update of attachment 115696 [details])
> LGTM but lets get someone working on fixing this. When the prerenderer patch lands, we're gonna need this I fear.

Just for completeness, can you please point to our so-called "prerenderer patch"?  Or are you just referring to intended design that we're working towards?
Comment 6 Adrienne Walker 2011-11-17 15:33:34 PST 
(In reply to comment #5)

> Just for completeness, can you please point to our so-called "prerenderer patch"?  Or are you just referring to intended design that we're working towards?

Eric Penner sounded like he'd have a patch up soon.
Comment 7 WebKit Review Bot 2011-11-17 20:09:21 PST 
Comment on attachment 115696 [details]
Patch

Clearing flags on attachment: 115696

Committed r100710: <http://trac.webkit.org/changeset/100710>
Comment 8 WebKit Review Bot 2011-11-17 20:09:26 PST 
All reviewed patches have been landed.  Closing bug.