Bug 72665 - Switch to a more modern approach to retrieving the OS marketing version
: Switch to a more modern approach to retrieving the OS marketing version
Status: RESOLVED FIXED
: WebKit
WebKit Misc.
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-11-17 14:50 PST by
Modified: 2011-11-28 06:34 PST (History)


Attachments
Patch v1 (6.70 KB, patch)
2011-11-17 14:55 PST, Mark Rowe (bdash)
no flags Review Patch | Details | Formatted Diff | Diff
Patch v2 (9.79 KB, patch)
2011-11-27 15:02 PST, Mark Rowe (bdash)
mitz: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-11-17 14:50:34 PST
As it says!
------- Comment #1 From 2011-11-17 14:55:36 PST -------
Created an attachment (id=115694) [details]
Patch v1
------- Comment #2 From 2011-11-27 15:02:17 PST -------
Created an attachment (id=116682) [details]
Patch v2
------- Comment #3 From 2011-11-27 15:05:48 PST -------
(From update of attachment 116682 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=116682&action=review

> Source/WebCore/platform/mac/WebCoreSystemInterface.h:322
> +extern NSString* (*wkGetMacOSXVersionString)(void);

There should be a space after NSString
------- Comment #4 From 2011-11-27 15:48:17 PST -------
Landed in r101215.
------- Comment #5 From 2011-11-28 06:34:34 PST -------
Looks like this caused bug 73214.