Bug 72665 - Switch to a more modern approach to retrieving the OS marketing version
Summary: Switch to a more modern approach to retrieving the OS marketing version
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Rowe (bdash)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-17 14:50 PST by Mark Rowe (bdash)
Modified: 2011-11-28 06:34 PST (History)
1 user (show)

See Also:

Attachments
Patch v1 (6.70 KB, patch)
2011-11-17 14:55 PST, Mark Rowe (bdash) 		no flags Details | Formatted Diff | Diff
Patch v2 (9.79 KB, patch)
2011-11-27 15:02 PST, Mark Rowe (bdash) 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2011-11-17 14:50:34 PST 
As it says!
Comment 1 Mark Rowe (bdash) 2011-11-17 14:55:36 PST 
Created attachment 115694 [details]
Patch v1
Comment 2 Mark Rowe (bdash) 2011-11-27 15:02:17 PST 
Created attachment 116682 [details]
Patch v2
Comment 3 mitz 2011-11-27 15:05:48 PST 
Comment on attachment 116682 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=116682&action=review

> Source/WebCore/platform/mac/WebCoreSystemInterface.h:322
> +extern NSString* (*wkGetMacOSXVersionString)(void);

There should be a space after NSString
Comment 4 Mark Rowe (bdash) 2011-11-27 15:48:17 PST 
Landed in r101215.
Comment 5 Adam Roben (:aroben) 2011-11-28 06:34:34 PST 
Looks like this caused bug 73214.