Bug 72655 - [Chromium] Layout test does not return correct misspelling positions if there are multiple misspelled words.
Summary: [Chromium] Layout test does not return correct misspelling positions if there...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 71991
  Show dependency treegraph
 
Reported: 2011-11-17 14:19 PST by Shinya Kawanaka
Modified: 2011-11-20 22:28 PST (History)
4 users (show)

See Also:


Attachments
Patch (5.96 KB, patch)
2011-11-17 14:25 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Patch (5.96 KB, patch)
2011-11-17 14:27 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2011-11-17 14:19:53 PST
The calculation of 'offset' in WebViewHost::finishLastTextCheck() is wrong.
Thanks to this bug, the positions of misspelling words except the first one are wrong.
Comment 1 Shinya Kawanaka 2011-11-17 14:20:12 PST
I'm writing CL now.
Comment 2 Shinya Kawanaka 2011-11-17 14:25:20 PST
Created attachment 115680 [details]
Patch
Comment 3 Shinya Kawanaka 2011-11-17 14:27:30 PST
Created attachment 115682 [details]
Patch
Comment 4 Shinya Kawanaka 2011-11-17 14:42:20 PST
This is necessary to have a test for
https://bugs.webkit.org/show_bug.cgi?id=71991
Comment 5 Hajime Morrita 2011-11-20 20:55:45 PST
Comment on attachment 115682 [details]
Patch

Good catch ><
Thanks for this fix!
Comment 6 WebKit Review Bot 2011-11-20 22:28:23 PST
Comment on attachment 115682 [details]
Patch

Clearing flags on attachment: 115682

Committed r100887: <http://trac.webkit.org/changeset/100887>
Comment 7 WebKit Review Bot 2011-11-20 22:28:27 PST
All reviewed patches have been landed.  Closing bug.