72643 – [CMake] Add ENABLE_CLIENT_BASED_GEOLOCATION to cmakeconfig.h

Bug 72643 - [CMake] Add ENABLE_CLIENT_BASED_GEOLOCATION to cmakeconfig.h

Summary: [CMake] Add ENABLE_CLIENT_BASED_GEOLOCATION to cmakeconfig.h

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Tools / Tests (show other bugs)
Version:	528+ (Nightly build)
Hardware:	All All

Importance:	P2 Normal
Assignee:	Patrick R. Gansterer

URL:
Keywords:

Depends on:
Blocks:

Reported:	2011-11-17 12:25 PST by Patrick R. Gansterer
Modified:	2011-11-18 08:07 PST (History)
CC List:	3 users (show)

See Also:

Attachments
Patch (4.28 KB, patch) 2011-11-17 12:26 PST, Patrick R. Gansterer	no flags	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Patrick R. Gansterer 2011-11-17 12:25:30 PST

[CMake] Add ENABLE_CLIENT_BASED_GEOLOCATION to cmakeconfig.h

Comment 1 Patrick R. Gansterer 2011-11-17 12:26:22 PST

Created attachment 115658 [details]
Patch

Comment 2 Brent Fulgham 2011-11-17 14:04:06 PST

Comment on attachment 115658 [details]
Patch

Looks good to me. The supposedly-failing chromium tests can't possibly be affected by this change.

Comment 3 Patrick R. Gansterer 2011-11-17 14:05:49 PST

Comment on attachment 115658 [details]
Patch

(In reply to comment #2)
> (From update of attachment 115658 [details])
> Looks good to me. The supposedly-failing chromium tests can't possibly be affected by this change.

Since chromium does not use CMake: NO! ;-)

Comment 4 WebKit Review Bot 2011-11-17 15:15:14 PST

Comment on attachment 115658 [details]
Patch

Clearing flags on attachment: 115658

Committed r100686: <http://trac.webkit.org/changeset/100686>

Comment 5 WebKit Review Bot 2011-11-17 15:15:18 PST

All reviewed patches have been landed.  Closing bug.

Comment 6 Raphael Kubo da Costa (:rakuco) 2011-11-18 08:07:24 PST

This patch broke the EFL build with ENABLE_GEOLOCATION (and most likely platform/mock/GeolocationServiceMock.cpp too), as they do not check for ENABLE_CLIENT_BASED_GEOLOCATION and define s_factoryFunction regardless of whether GeolocationService.cpp also does so.