Bug 72636 - fuzzy_match doesn't recognize "Dan B" or "hyatt"
: fuzzy_match doesn't recognize "Dan B" or "hyatt"
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Tools / Tests
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Ryosuke Niwa
:
Depends on:
Blocks: 26533 72243
  Show dependency treegraph
 
Reported: 2011-11-17 11:46 PST by Ryosuke Niwa
Modified: 2011-11-17 16:46 PST (History)
4 users (show)

See Also:


Attachments
fixes the bug (15.95 KB, patch)
2011-11-17 12:16 PST, Ryosuke Niwa
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-11-17 11:46:39 PST
fuzzy_match should be able to recognize "Dan B" and "hyatt".
Comment 1 Ryosuke Niwa 2011-11-17 12:16:46 PST
Created attachment 115653 [details]
fixes the bug
Comment 2 Eric Seidel 2011-11-17 12:37:49 PST
Comment on attachment 115653 [details]
fixes the bug

Curious if you looked at bug 26533 at all.  It had to solve these very same problems.  (You're doing a much nicer job, of course.) :)
Comment 3 Ryosuke Niwa 2011-11-17 12:39:39 PST
(In reply to comment #2)
> (From update of attachment 115653 [details])
> Curious if you looked at bug 26533 at all.  It had to solve these very same problems.  (You're doing a much nicer job, of course.) :)

Yeah, I've looked at your script. What I'm trying to do is to minimize the hard-coded list of things so that it can adopt to new misspells and new contributors better. Eventually, fuzz_match should be able to recognize any name listed in your original script :)
Comment 4 Ryosuke Niwa 2011-11-17 16:17:59 PST
Do you have any suggestion to the patch?
Comment 5 Eric Seidel 2011-11-17 16:21:47 PST
Comment on attachment 115653 [details]
fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=115653&action=review

Seems OK.  You should add a comment about the commented out code, since we don't normally commit commented out code.

> Tools/Scripts/webkitpy/common/config/committers.py:539
> +                if email[:len(string)] == string:

Why not just .startswith?

> Tools/Scripts/webkitpy/common/config/committers.py:545
> +        if not ' ' in contributor.full_name:

' ' not in foo
works too.

> Tools/Scripts/webkitpy/common/config/committers.py:550
> +        first_name = split_fullname[0]
> +        last_name = split_fullname[-1]
> +        return first_name, last_name, first_name + last_name[0], first_name + ' ' + last_name[0]

This is kinda a big hack, but OK.  You might want to put this on Contributor itself in a later patch. Not sure.
Comment 6 Ryosuke Niwa 2011-11-17 16:43:00 PST
Thanks for the review. Will address all comments and land.
Comment 7 Ryosuke Niwa 2011-11-17 16:46:10 PST
Committed r100700: <http://trac.webkit.org/changeset/100700>