Bug 72635 - NRWT crashes when parsing leaks files from which certain leaks were excluded
Summary: NRWT crashes when parsing leaks files from which certain leaks were excluded
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-17 11:43 PST by Adam Roben (:aroben)
Modified: 2011-11-17 11:58 PST (History)
6 users (show)

See Also:

Attachments
Patch (5.16 KB, patch)
2011-11-17 11:43 PST, Adam Roben (:aroben) 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-11-17 11:43:16 PST 
NRWT crashes when parsing leaks files from which certain leaks were excluded
Comment 1 Adam Roben (:aroben) 2011-11-17 11:43:41 PST 
Created attachment 115640 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-11-17 11:55:38 PST 
Comment on attachment 115640 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115640&action=review

> Tools/Scripts/webkitpy/layout_tests/port/leakdetector.py:99
> -        excluded = excluded_match.group(0) if excluded_match else 0
> +        excluded = excluded_match.group('excluded') if excluded_match else 0

Sorry.  I think I broke this last time I was in here.  Again, sadly untested and thus broke.  Thanks!
Comment 3 Adam Roben (:aroben) 2011-11-17 11:58:59 PST 
Committed r100655: <http://trac.webkit.org/changeset/100655>