Bug 72625 - [WK2] Fix TransformOperation serialization
Summary: [WK2] Fix TransformOperation serialization
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-17 09:49 PST by Igor Trindade Oliveira
Modified: 2011-11-17 14:49 PST (History)
4 users (show)

See Also:


Attachments
Patch (17.54 KB, patch)
2011-11-17 10:05 PST, Igor Trindade Oliveira
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Igor Trindade Oliveira 2011-11-17 09:49:03 PST
TransformOperation subclasses are being serialized using SimpleArgumentCoder. However, SimpleArgumentCoder uses memcpy to decode the data, so the objects serialized by it needs to be a POD(Plain Old Data) type and TransformOperation subclasses are not because the base class has pure virtual methods.
Comment 1 Igor Trindade Oliveira 2011-11-17 10:05:46 PST
Created attachment 115612 [details]
Patch

Proposed patch.
Comment 2 WebKit Review Bot 2011-11-17 14:49:44 PST
Comment on attachment 115612 [details]
Patch

Clearing flags on attachment: 115612

Committed r100680: <http://trac.webkit.org/changeset/100680>
Comment 3 WebKit Review Bot 2011-11-17 14:49:48 PST
All reviewed patches have been landed.  Closing bug.