Bug 72620 - Make check-webkit-style accept xxx_p.h as a primary header for xxx.cpp for Qt's sake
Summary: Make check-webkit-style accept xxx_p.h as a primary header for xxx.cpp for Qt...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Caio Marcelo de Oliveira Filho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-17 08:27 PST by Caio Marcelo de Oliveira Filho
Modified: 2011-11-17 14:35 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.88 KB, patch)
2011-11-17 08:32 PST, Caio Marcelo de Oliveira Filho 		no flags Details | Formatted Diff | Diff
Patch (3.19 KB, patch)
2011-11-17 09:37 PST, Caio Marcelo de Oliveira Filho 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Marcelo de Oliveira Filho 2011-11-17 08:27:36 PST 
Make check-webkit-style accept xxx_p.h as a primary header for xxx.cpp for Qt's sake
Comment 1 Caio Marcelo de Oliveira Filho 2011-11-17 08:32:07 PST 
Created attachment 115598 [details]
Patch
Comment 2 Caio Marcelo de Oliveira Filho 2011-11-17 09:27:37 PST 
Comment on attachment 115598 [details]
Patch

Forgot the unittests.
Comment 3 Caio Marcelo de Oliveira Filho 2011-11-17 09:37:52 PST 
Created attachment 115606 [details]
Patch
Comment 4 David Levin 2011-11-17 11:39:20 PST 
Comment on attachment 115606 [details]
Patch

thanks for adding a test.
Comment 5 WebKit Review Bot 2011-11-17 14:35:16 PST 
Comment on attachment 115606 [details]
Patch

Clearing flags on attachment: 115606

Committed r100678: <http://trac.webkit.org/changeset/100678>
Comment 6 WebKit Review Bot 2011-11-17 14:35:20 PST 
All reviewed patches have been landed.  Closing bug.