Bug 72615 – Chromium Mac 10.5 CG dbg bots are failing to run webkit_gpu_tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Steve Block]

See http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5%20%28CG%29%28dbg%29%281%29/builds/895

It looks like the test manager script isn't designed to handle only 1 test being run ...

2011-11-17 07:24:10,271 37811 printing.py:462 INFO Preparing tests ...
2011-11-17 07:24:10,271 37811 printing.py:462 INFO Found:  1 tests
Traceback (most recent call last):
  File "/b/build/slave/Webkit_Mac10_5__CG__dbg__1_/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 420, in <module>
    sys.exit(main())
  File "/b/build/slave/Webkit_Mac10_5__CG__dbg__1_/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 415, in main
    return run(port, options, args)
  File "/b/build/slave/Webkit_Mac10_5__CG__dbg__1_/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 86, in run
    result_summary = manager.set_up_run()
  File "/b/build/slave/Webkit_Mac10_5__CG__dbg__1_/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 877, in set_up_run
    result_summary = self.prepare_lists_and_print_output()
  File "/b/build/slave/Webkit_Mac10_5__CG__dbg__1_/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 514, in prepare_lists_and_print_output
    skipped = self._split_into_chunks_if_necessary(skipped)
  File "/b/build/slave/Webkit_Mac10_5__CG__dbg__1_/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 426, in _split_into_chunks_if_necessary
    assert(test_size <= num_tests)
AssertionError

On Webkit Mac10.5 (CG)(dbg)(1), the problem started some time between build 878 and 891 (WebKit r100341 to r559). It's not clear exactly when because the test_expectations file was broken in this range, causing the test run to fail for other reasons.

I suspect this is something to do with the recent changes made by jamesr, regarding not running CG tests on Mac 10.5, but I can't find the change he made.

[James Robinson]

Note that zero tests should run on the 10.5 bots in webkit_gpu_tests, so we aren't losing any actual coverage here.

[Dirk Pranke]

Ah, interesting. I can believe we don't have tests for this. Will fix later this morning.

[Dirk Pranke]

Created attachment 115654 [details]
Patch

[Dirk Pranke]

Okay, for now I'll just run a few more dummy tests, since it's not obvious what the right way to fix things is - should each shard run the same test? etc.

Also, it looks like eric refactored that part of the code in a way that's a little weird, so I want to clean it up separately.

[Dirk Pranke]

Comment on attachment 115654 [details]
Patch

Clearing flags on attachment: 115654

Committed r100673: <http://trac.webkit.org/changeset/100673>

[Dirk Pranke]

All reviewed patches have been landed.  Closing bug.