Bug 72611 - MediaStream API: Merging the PeerConnectionHandler.h files
Summary: MediaStream API: Merging the PeerConnectionHandler.h files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Tommy Widenflycht
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-17 07:57 PST by Tommy Widenflycht
Modified: 2011-11-18 02:05 PST (History)
4 users (show)

See Also:

Attachments
Patch (13.47 KB, patch)
2011-11-17 08:00 PST, Tommy Widenflycht 		no flags Details | Formatted Diff | Diff
Patch (13.53 KB, patch)
2011-11-18 00:30 PST, Tommy Widenflycht 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tommy Widenflycht 2011-11-17 07:57:26 PST 
As discussed a while back Ericsson expressed a wish for the header files to be unified, and as long as the #ifdefs are kept to a minimum I see the advantage.
Comment 1 Tommy Widenflycht 2011-11-17 08:00:58 PST 
Created attachment 115590 [details]
Patch
Comment 2 WebKit Review Bot 2011-11-17 08:43:32 PST 
Comment on attachment 115590 [details]
Patch

Attachment 115590 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10312190
Comment 3 Adam Barth 2011-11-17 10:28:47 PST 
Comment on attachment 115590 [details]
Patch

Ok.
Comment 4 Tommy Widenflycht 2011-11-18 00:30:42 PST 
Created attachment 115754 [details]
Patch
Comment 5 WebKit Review Bot 2011-11-18 02:05:32 PST 
Comment on attachment 115754 [details]
Patch

Clearing flags on attachment: 115754

Committed r100734: <http://trac.webkit.org/changeset/100734>
Comment 6 WebKit Review Bot 2011-11-18 02:05:37 PST 
All reviewed patches have been landed.  Closing bug.