Bug 72607 - Print warning for the Qt port when a process crashes and is relaunched
Summary: Print warning for the Qt port when a process crashes and is relaunched
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenneth Rohde Christiansen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-17 06:40 PST by Kenneth Rohde Christiansen
Modified: 2011-11-17 07:39 PST (History)
5 users (show)

See Also:


Attachments
Patch (10.71 KB, patch)
2011-11-17 06:42 PST, Kenneth Rohde Christiansen
no flags Details | Formatted Diff | Diff
Patch (6.56 KB, patch)
2011-11-17 07:25 PST, Kenneth Rohde Christiansen
tonikitoo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Rohde Christiansen 2011-11-17 06:40:24 PST
SSIA
Comment 1 Kenneth Rohde Christiansen 2011-11-17 06:42:27 PST
Created attachment 115580 [details]
Patch
Comment 2 WebKit Review Bot 2011-11-17 06:46:08 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 zalan 2011-11-17 06:58:22 PST
+ const String url = m_mainFrame->url();
WebPageProxy functions usually check against !m_mainFrame

in N9 codebase, we've got 
loadStateAtProcessExit()
urlAtProcessExit()
functions to also cancel pending loads, when the process exits. Wondering if passing the url (and loading state?) around is the preferred way now.
Comment 4 Simon Hausmann 2011-11-17 07:00:28 PST
Comment on attachment 115580 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115580&action=review

> Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp:680
> +    m_viewInterface->processDidCrash(QUrl(url));

It's not your fault, but this part of converting the QString to a QURL is wrong.

We are missing a convenience function, but conceptually we should use:

WebCore::KURL kurl(WebCore::ParsedURLStringTag, url);
QUrl qurl(kurl);
Comment 5 Kenneth Rohde Christiansen 2011-11-17 07:25:25 PST
Created attachment 115584 [details]
Patch
Comment 6 Antonio Gomes 2011-11-17 07:34:35 PST
Comment on attachment 115584 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115584&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:3087
> +    const String url = m_mainFrame->url();
> +

do you need this one?
Comment 7 Kenneth Rohde Christiansen 2011-11-17 07:38:51 PST
Comment on attachment 115584 [details]
Patch

Committed (with fix) r100621