Bug 72607 – Print warning for the Qt port when a process crashes and is relaunched

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Kenneth Rohde Christiansen]

SSIA

[Kenneth Rohde Christiansen]

Created attachment 115580 [details]
Patch

[WebKit Review Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[alan]

+ const String url = m_mainFrame->url();
WebPageProxy functions usually check against !m_mainFrame

in N9 codebase, we've got 
loadStateAtProcessExit()
urlAtProcessExit()
functions to also cancel pending loads, when the process exits. Wondering if passing the url (and loading state?) around is the preferred way now.

[Simon Hausmann]

Comment on attachment 115580 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115580&action=review

> Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp:680
> +    m_viewInterface->processDidCrash(QUrl(url));

It's not your fault, but this part of converting the QString to a QURL is wrong.

We are missing a convenience function, but conceptually we should use:

WebCore::KURL kurl(WebCore::ParsedURLStringTag, url);
QUrl qurl(kurl);

[Kenneth Rohde Christiansen]

Created attachment 115584 [details]
Patch

[Antonio Gomes]

Comment on attachment 115584 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115584&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:3087
> +    const String url = m_mainFrame->url();
> +

do you need this one?

[Kenneth Rohde Christiansen]

Comment on attachment 115584 [details]
Patch

Committed (with fix) r100621