Bug 72602 - [Qt] REGRESSION(r100510): Enable 8 Bit Strings in JavaScriptCore
Summary: [Qt] REGRESSION(r100510): Enable 8 Bit Strings in JavaScriptCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-17 04:54 PST by Gabor Loki
Modified: 2011-11-17 23:44 PST (History)
4 users (show)

See Also:


Attachments
Proposed Patch (3.75 KB, patch)
2011-11-17 11:51 PST, Michael Saboff
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Loki 2011-11-17 04:54:12 PST
Four tests were broken after
http://trac.webkit.org/changeset/100510

The pretty diff can be see at bug 71337 or
http://build.webkit.org/results/Qt%20Linux%20Release/r100512%20(39877)/results.html

Those tests are using several Unicode characters and the FindString function.

The tests will be skipped until a fix.
Comment 1 Gabor Loki 2011-11-17 05:05:43 PST
The tests were skipped in http://trac.webkit.org/changeset/100608
Comment 2 Michael Saboff 2011-11-17 09:41:13 PST
These tests work fine on Mac.  The problem appears to be in WebCore/editing/TextIterator.cpp when WTF_USE_ICU_UNICODE is 0.  Continuing to investigate.
Comment 3 Michael Saboff 2011-11-17 11:51:42 PST
Created attachment 115643 [details]
Proposed Patch

I debugged and fixed this issue on a Mac by locally disabling WTF_USE_ICU_UNICODE in WebCore/editing/TextIterator.cpp.  The proposed patch fixed the issues, but the expected results for the impacted tests as well as a few others are different on Mac than on qt.  Therefore I'd like someone working on qt to verify that this does fix the test failures in a qt build.
Comment 4 Gabor Loki 2011-11-17 13:01:03 PST
> Created an attachment (id=115643) [details]

You are great! I can confirm that the patch fixes those tests.
Thank you very much!
Comment 5 Michael Saboff 2011-11-17 13:05:29 PST
(In reply to comment #4)
> > Created an attachment (id=115643) [details] [details]
> 
> You are great! I can confirm that the patch fixes those tests.
> Thank you very much!

Do you want me to add the changes to relabel the skipped tests?
Comment 6 Gabor Loki 2011-11-17 14:10:21 PST
If you have time to create another patch which relabels those tests as well, please do it. Otherwise I will take care of them tomorrow. Thanks again!
Comment 7 Zoltan Herczeg 2011-11-17 23:23:36 PST
Comment on attachment 115643 [details]
Proposed Patch

rs=me
Comment 8 Gabor Loki 2011-11-17 23:43:20 PST
Comment on attachment 115643 [details]
Proposed Patch

Landed in http://trac.webkit.org/changeset/100729
Comment 9 Gabor Loki 2011-11-17 23:44:22 PST
The tests are enabled in http://trac.webkit.org/changeset/100730