Bug 72597 – [Qt] Layer violation: ThirdPartyCookiesQt.cpp uses QWebSettings in two places

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Simon Hausmann]

We should pass the NetworkingContext instead and add missing functionality there as interface between WebCore and WebKit.

[Simon Hausmann]

Created attachment 115577 [details]
[Qt] Layer violation: ThirdPartyCookiesQt.cpp uses QWebSettings in two places

[Tor Arne Vestbø]

Comment on attachment 115577 [details]
[Qt] Layer violation: ThirdPartyCookiesQt.cpp uses QWebSettings in two places

View in context: https://bugs.webkit.org/attachment.cgi?id=115577&action=review

> Source/WebKit/qt/Api/qwebsettings.cpp:401
>  

All the other settings have a verb, Always_allow_, etc. Perhaps UseGlobalSetting? Come to think of it, isn't this handled by "If a setting is not configured, then it is looked
up in the global settings object, which can be accessed using globalSettings()". Ie, do we need an enum for it, or is the behavior enough?

[Simon Hausmann]

(In reply to comment #2)
> (From update of attachment 115577 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=115577&action=review
> 
> > Source/WebKit/qt/Api/qwebsettings.cpp:401
> >  
> 
> All the other settings have a verb, Always_allow_, etc. Perhaps UseGlobalSetting? Come to think of it, isn't this handled by "If a setting is not configured, then it is looked
> up in the global settings object, which can be accessed using globalSettings()". Ie, do we need an enum for it, or is the behavior enough?

Yeah the main issue is that the "inheritance" of settings from global settings only works for things that can be enabled, disabled or unset. For the enum the "unset" option is what the patch adds.

Another option would be to just keep the old behaviour and say that the setting only has an effect on QWebSettings::globalSettings(). But now that we _can_ support it per page, we might as well.

How about QWebSettings::UseGlobalThirdPartyCookieSetting ?

[Simon Hausmann]

For the time being I'm preparing a patch that doesn't change the behaviour, i.e. always query QWebSettings::globalSettings().

[Simon Hausmann]

Created attachment 115751 [details]
Updated patch with no qwebsettings changes

[Simon Hausmann]

Committed r100731: <http://trac.webkit.org/changeset/100731>