Bug 72594 - [Qt] Layer violation: Image::loadPlatformResource uses QWebSettings::webGraphic
Summary: [Qt] Layer violation: Image::loadPlatformResource uses QWebSettings::webGraphic
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 72593
  Show dependency tree / graph
 
Reported: 2011-11-17 03:58 PST by Simon Hausmann
Modified: 2011-11-17 06:23 PST (History)
1 user (show)

See Also:

Attachments
[Qt] Layer violation: Image::loadPlatformResource uses QWebSettings::webGraphic (10.40 KB, patch)
2011-11-17 04:23 PST, Simon Hausmann 		no flags Details | Formatted Diff | Diff
[Qt] Layer violation: Image::loadPlatformResource uses QWebSettings::webGraphic (10.44 KB, patch)
2011-11-17 04:33 PST, Simon Hausmann 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Hausmann 2011-11-17 03:58:19 PST 
SSIA
Comment 1 Simon Hausmann 2011-11-17 04:23:35 PST 
Created attachment 115559 [details]
[Qt] Layer violation: Image::loadPlatformResource uses QWebSettings::webGraphic
Comment 2 WebKit Review Bot 2011-11-17 04:28:30 PST 
Attachment 115559 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/platform/graphics/qt/ImageQt.cpp:50:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Hausmann 2011-11-17 04:33:41 PST 
Created attachment 115561 [details]
[Qt] Layer violation: Image::loadPlatformResource uses QWebSettings::webGraphic
Comment 4 Simon Hausmann 2011-11-17 06:22:57 PST 
Comment on attachment 115561 [details]
[Qt] Layer violation: Image::loadPlatformResource uses QWebSettings::webGraphic

Clearing flags on attachment: 115561

Committed r100613: <http://trac.webkit.org/changeset/100613>
Comment 5 Simon Hausmann 2011-11-17 06:23:04 PST 
All reviewed patches have been landed.  Closing bug.