Bug 72592 - [GTK] ATK API tests failing because of patch for bug 72390
Summary: [GTK] ATK API tests failing because of patch for bug 72390
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Reported: 2011-11-17 03:21 PST by Mario Sanchez Prada
Modified: 2011-11-17 03:47 PST (History)
1 user (show)

See Also:

Patch proposal (3.88 KB, patch)
2011-11-17 03:26 PST, Mario Sanchez Prada
pnormand: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mario Sanchez Prada 2011-11-17 03:21:45 PST
The following errors have been observed in the GTK bots after applying the patches for bug 72390:

  TEST: /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/Programs/unittests/testatk... (pid=1726)
  ERROR:../../Source/WebKit/gtk/tests/testatk.c:1628:testWebkitAtkParentForRootObject: assertion failed (atk_object_get_n_accessible_children(axBox) == 1): (0 == 1)

The problem here is that the get_n_accessible_children() line shouldn't be placed there but, in any case, after the ref_child() (in the followin line), so it's 100% sure the parent object will report the right number of children (atkobjects are lazyly created). Actually it shouldn't be there at all since it's not actually needed for the functionality that is being tested, so I'd rather remove it.

  TEST: /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/Programs/unittests/testatkroles... (pid=1735)
  ERROR:../../Source/WebKit/gtk/tests/testatkroles.c:106:test_webkit_atk_get_role_document_frame: assertion failed: (fixture->role == ATK_ROLE_DOCUMENT_FRAME)

The problem here is that I missed to adapt testatkroles.c to properly find the document frame (which is no longer the root object in the hierarchy), so this will need a patch to reflect the shift in the hierarchy.
Comment 1 Mario Sanchez Prada 2011-11-17 03:26:35 PST
Created attachment 115554 [details]
Patch proposal
Comment 2 Philippe Normand 2011-11-17 03:39:43 PST
Comment on attachment 115554 [details]
Patch proposal

Looks good!
Comment 3 Mario Sanchez Prada 2011-11-17 03:47:45 PST
Committed r100596: <http://trac.webkit.org/changeset/100596>