WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
72592
[GTK] ATK API tests failing because of patch for
bug 72390
https://bugs.webkit.org/show_bug.cgi?id=72592
Summary
[GTK] ATK API tests failing because of patch for bug 72390
Mario Sanchez Prada
Reported
2011-11-17 03:21:45 PST
The following errors have been observed in the GTK bots after applying the patches for
bug 72390
: TEST: /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/Programs/unittests/testatk... (pid=1726) ** ERROR:../../Source/WebKit/gtk/tests/testatk.c:1628:testWebkitAtkParentForRootObject: assertion failed (atk_object_get_n_accessible_children(axBox) == 1): (0 == 1) The problem here is that the get_n_accessible_children() line shouldn't be placed there but, in any case, after the ref_child() (in the followin line), so it's 100% sure the parent object will report the right number of children (atkobjects are lazyly created). Actually it shouldn't be there at all since it's not actually needed for the functionality that is being tested, so I'd rather remove it. TEST: /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/Programs/unittests/testatkroles... (pid=1735) ** ERROR:../../Source/WebKit/gtk/tests/testatkroles.c:106:test_webkit_atk_get_role_document_frame: assertion failed: (fixture->role == ATK_ROLE_DOCUMENT_FRAME) The problem here is that I missed to adapt testatkroles.c to properly find the document frame (which is no longer the root object in the hierarchy), so this will need a patch to reflect the shift in the hierarchy.
Attachments
Patch proposal
(3.88 KB, patch)
2011-11-17 03:26 PST
,
Mario Sanchez Prada
pnormand
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mario Sanchez Prada
Comment 1
2011-11-17 03:26:35 PST
Created
attachment 115554
[details]
Patch proposal
Philippe Normand
Comment 2
2011-11-17 03:39:43 PST
Comment on
attachment 115554
[details]
Patch proposal Looks good!
Mario Sanchez Prada
Comment 3
2011-11-17 03:47:45 PST
Committed
r100596
: <
http://trac.webkit.org/changeset/100596
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug