Bug 72576 - [chromium] Add some useful text to existing debug dump
Summary: [chromium] Add some useful text to existing debug dump
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shawn Singh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-16 18:34 PST by Shawn Singh
Modified: 2011-11-18 16:15 PST (History)
5 users (show)

See Also:


Attachments
Patch (3.63 KB, patch)
2011-11-16 18:39 PST, Shawn Singh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shawn Singh 2011-11-16 18:34:50 PST
The --show-composited-layer-tree flag shows a useful dump of the tree as text, but I had to modify it and then revert it for several patches already.  Could we just add this information into the debug dump so its always there?

Specifically:
  (1) adding the draw transform for RenderSurfaces, and
  (2) using "//" as a divider between columns to visualize the matrix more easily.

Patch is coming in just a moment.
Comment 1 Shawn Singh 2011-11-16 18:39:39 PST
Created attachment 115511 [details]
Patch
Comment 2 Adrienne Walker 2011-11-17 09:42:30 PST
That looks really useful.  This change looks good to me.
Comment 3 Kenneth Russell 2011-11-18 14:00:54 PST
Comment on attachment 115511 [details]
Patch

Does this change affect any layout tests? These are called from CCLayerImpl::layerTreeAsText() but I don't know whether that's related to LayoutTestController's similarly named functionality.
Comment 4 Shawn Singh 2011-11-18 15:03:50 PST
(In reply to comment #3)
> (From update of attachment 115511 [details])
> Does this change affect any layout tests? These are called from CCLayerImpl::layerTreeAsText() but I don't know whether that's related to LayoutTestController's similarly named functionality.

No, this is simply a debug dump local to our compositor code that is visualized with --show-composited-layer-tree command-line flag.  Just in case, I also double-checked layout tests before and after this patch, and I don't see any obvious regressions.
Comment 5 WebKit Review Bot 2011-11-18 16:15:05 PST
Comment on attachment 115511 [details]
Patch

Clearing flags on attachment: 115511

Committed r100823: <http://trac.webkit.org/changeset/100823>
Comment 6 WebKit Review Bot 2011-11-18 16:15:09 PST
All reviewed patches have been landed.  Closing bug.