Bug 72576 – [chromium] Add some useful text to existing debug dump

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Shawn Singh]

The --show-composited-layer-tree flag shows a useful dump of the tree as text, but I had to modify it and then revert it for several patches already.  Could we just add this information into the debug dump so its always there?

Specifically:
  (1) adding the draw transform for RenderSurfaces, and
  (2) using "//" as a divider between columns to visualize the matrix more easily.

Patch is coming in just a moment.

[Shawn Singh]

Created attachment 115511 [details]
Patch

[Adrienne Walker]

That looks really useful.  This change looks good to me.

[Kenneth Russell]

Comment on attachment 115511 [details]
Patch

Does this change affect any layout tests? These are called from CCLayerImpl::layerTreeAsText() but I don't know whether that's related to LayoutTestController's similarly named functionality.

[Shawn Singh]

(In reply to comment #3)
> (From update of attachment 115511 [details])
> Does this change affect any layout tests? These are called from CCLayerImpl::layerTreeAsText() but I don't know whether that's related to LayoutTestController's similarly named functionality.

No, this is simply a debug dump local to our compositor code that is visualized with --show-composited-layer-tree command-line flag.  Just in case, I also double-checked layout tests before and after this patch, and I don't see any obvious regressions.

[WebKit Review Bot]

Comment on attachment 115511 [details]
Patch

Clearing flags on attachment: 115511

Committed r100823: <http://trac.webkit.org/changeset/100823>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.