Bug 72573 - WebKit does not send mouse down/up/click events to ARIA tabs
Summary: WebKit does not send mouse down/up/click events to ARIA tabs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: chris fleizach
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-11-16 18:15 PST by chris fleizach
Modified: 2011-11-30 17:05 PST (History)
1 user (show)

See Also:

Attachments
patch (5.28 KB, patch)
2011-11-18 12:59 PST, chris fleizach 		bdakin: review-
Details | Formatted Diff | Diff
patch (6.75 KB, patch)
2011-11-30 16:16 PST, chris fleizach 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2011-11-16 18:15:34 PST 
WK needs to send click() when there's no actionElement
Comment 1 chris fleizach 2011-11-18 12:54:50 PST 
There are some more control type elements that should send the click event too when targeted
Comment 2 chris fleizach 2011-11-18 12:59:08 PST 
rdar://10444670
Comment 3 chris fleizach 2011-11-18 12:59:45 PST 
Created attachment 115851 [details]
patch
Comment 4 Beth Dakin 2011-11-30 14:27:58 PST 
Comment on attachment 115851 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115851&action=review

Overall, this seems good, but since I have one issue above and there are no ChangeLogs, I am going to r- for the time being. I will definitely r+ once you address those things though.

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:881
> +    case RadioButtonRole:

This shouldn't be necessary since this case should fall into the earlier conditional check: if (AccessibilityObject::isARIAInput(ariaRoleAttribute())). Right?

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:882
> +    case CheckBoxRole:

Same for this one.
Comment 5 chris fleizach 2011-11-30 16:16:57 PST 
Created attachment 117291 [details]
patch
Comment 6 Darin Adler 2011-11-30 16:25:09 PST 
Comment on attachment 117291 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117291&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:883
>          return static_cast<Element*>(m_renderer->node()); 

This should use the toElement checked cast instead of static_cast.
Comment 7 chris fleizach 2011-11-30 17:03:42 PST 
http://trac.webkit.org/changeset/101571
Comment 8 chris fleizach 2011-11-30 17:05:43 PST 
http://trac.webkit.org/changeset/101572