Bug 72561 - LayoutTests for Debug Builds Crashes in JavaScriptCore/yarr/YarrInterpreter.cpp(185)
Summary: LayoutTests for Debug Builds Crashes in JavaScriptCore/yarr/YarrInterpreter.c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Critical
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-16 16:07 PST by Michael Saboff
Modified: 2011-11-16 16:25 PST (History)
0 users

See Also:


Attachments
Patch (2.55 KB, patch)
2011-11-16 16:22 PST, Michael Saboff
jamesr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2011-11-16 16:07:55 PST
The crash happens in

        CharAccess(const UString& s)
            : m_buffer(0)
        {
            if (s.is8Bit()) {
#if USE(JSC)
                m_charSize = Char8;
                unsigned length = s.length();
                m_ptr.ptr8 = m_buffer = static_cast<char *>(fastMalloc(length));
                memcpy(m_buffer, s.latin1().data(), length);
#else
                ASSERT_NOT_REACHED();   <=== This line is crashing
#endif
            } else {
                m_charSize = Char16;
                m_ptr.ptr16 = s.characters();
            }
        }
Comment 1 Michael Saboff 2011-11-16 16:22:09 PST
Created attachment 115475 [details]
Patch
Comment 2 James Robinson 2011-11-16 16:24:51 PST
Comment on attachment 115475 [details]
Patch

Looks good
Comment 3 Michael Saboff 2011-11-16 16:25:43 PST
Committed r100523: <http://trac.webkit.org/changeset/100523>