RESOLVED FIXED 72548
De-virtualize ExecutableBase::intrinsic 
https://bugs.webkit.org/show_bug.cgi?id=72548
Summary De-virtualize ExecutableBase::intrinsic
Mark Hahnenberg
Reported 2011-11-16 14:28:08 PST
We can leverage JSType again by adding a new value for NativeExecutable, which is the only class that overrides intrinsic.
Attachments
Patch (4.90 KB, patch)
2011-11-16 14:31 PST, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (3.34 KB, patch)
2011-11-16 17:04 PST, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2011-11-16 14:31:01 PST
Created attachment 115450 [details] Patch
Geoffrey Garen
Comment 2 2011-11-16 15:20:07 PST
Comment on attachment 115450 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115450&action=review r=me > Source/JavaScriptCore/runtime/Executable.cpp:57 > + if (structure()->typeInfo().type() == NativeExecutableType) > + return jsCast<const NativeExecutable*>(this)->intrinsic(); Could just use classInfo here instead of a type flag. I mention this because it might be nice to deploy jsDynamicCast here, and I assume jsDynamicCast would be based on ClassInfo. > Source/JavaScriptCore/runtime/JSType.h:54 > }; Do we really need to spell these constants out explicitly? Do their bits have any meaning?
Mark Hahnenberg
Comment 3 2011-11-16 17:04:01 PST
Created attachment 115486 [details] Patch
WebKit Review Bot
Comment 4 2011-11-18 14:13:54 PST
Comment on attachment 115486 [details] Patch Clearing flags on attachment: 115486 Committed r100810: <http://trac.webkit.org/changeset/100810>
WebKit Review Bot
Comment 5 2011-11-18 14:13:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.