Bug 72544 - DropShadowFilterOperation violates platform isolation
Summary: DropShadowFilterOperation violates platform isolation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-11-16 13:59 PST by Dean Jackson
Modified: 2011-11-16 21:26 PST (History)
6 users (show)

See Also:

Attachments
Patch (5.21 KB, patch)
2011-11-16 14:55 PST, Dean Jackson 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2011-11-16 13:59:50 PST 
The DropShadowFilterOperation references ShadowData. It shouldn't.
Comment 1 Radar WebKit Bug Importer 2011-11-16 14:00:17 PST 
<rdar://problem/10457784>
Comment 2 Dean Jackson 2011-11-16 14:55:48 PST 
Created attachment 115456 [details]
Patch
Comment 3 Dean Jackson 2011-11-16 14:56:46 PST 
Oops - and I'll remove the #include too.
Comment 4 Simon Fraser (smfr) 2011-11-16 17:33:31 PST 
Comment on attachment 115456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115456&action=review

> Source/WebCore/platform/graphics/filters/FilterOperation.h:271
>  class DropShadowFilterOperation : public FilterOperation {

Isn't there a ShadowData include that could be removed now?
Comment 5 Dean Jackson 2011-11-16 21:26:06 PST 
http://trac.webkit.org/changeset/100560