WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
72541
Remove HTMLTableElement dependency on CSSMutableStyleDeclaration::setNode
https://bugs.webkit.org/show_bug.cgi?id=72541
Summary
Remove HTMLTableElement dependency on CSSMutableStyleDeclaration::setNode
Rafael Weinstein
Reported
2011-11-16 13:26:43 PST
It looks to me the setting the node and then immediately unsetting it shortly after doesn't have any effect any more. CSSMutableStyle only seems to use the node for notification purposes, but all of the setProperty calls are notifyChange == false. I'd like to test this hypothesis
Attachments
Patch
(4.55 KB, patch)
2011-11-16 13:36 PST
,
Rafael Weinstein
koivisto
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Rafael Weinstein
Comment 1
2011-11-16 13:36:02 PST
Created
attachment 115438
[details]
Patch
Antti Koivisto
Comment 2
2011-11-16 14:01:45 PST
Comment on
attachment 115438
[details]
Patch r=me if the tests pass
Rafael Weinstein
Comment 3
2011-11-16 16:10:26 PST
I was thrown off by the multiple call signatures to setProperty. These calls are actually requesting notifyChanged() and this patch is causing crashes which seems to be coming from within recalcStyleSelector =-(
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug