Bug 72540 - contributors_by_fuzzy_match is super slow
Summary: contributors_by_fuzzy_match is super slow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 72243
  Show dependency tree / graph
 
Reported: 2011-11-16 13:20 PST by Ryosuke Niwa
Modified: 2011-11-16 17:56 PST (History)
4 users (show)

See Also:

Attachments
Makes contributors_name do case insensitive comparison (4.45 KB, patch)
2011-11-16 13:28 PST, Ryosuke Niwa 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-11-16 13:20:12 PST 
contributors_by_fuzzy_match is super slow because it's calling self.contributor_by_name(string) where string is name in lowercase yet contributor_by_name doesn't do case-insensitive comparison
Comment 1 Ryosuke Niwa 2011-11-16 13:28:41 PST 
Created attachment 115436 [details]
Makes contributors_name do case insensitive comparison
Comment 2 Eric Seidel (no email) 2011-11-16 13:31:02 PST 
Comment on attachment 115436 [details]
Makes contributors_name do case insensitive comparison

OK.  We could probably also just use @memoized and not need our own custom cache here, but this is fine.
Comment 3 Ryosuke Niwa 2011-11-16 14:24:05 PST 
Committed r100505: <http://trac.webkit.org/changeset/100505>