Bug 72523 – AX: Searching mechanism is too slow when finding the element.

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

Right now the searching mechanism goes through every item starting at the first one in order to find where to start the search

Instead, it should start with the immediate parent chain of the element and start searching from there

[chris fleizach]

First patch will be too clean up this method...

Second patch will change the implementation

[chris fleizach]

So in summary, in the old approach, it literally went through every element, looking for the start element before, "starting" the search

In the new way, we only go through the elements that need to be searched. 

This happens by going up the start object parent chain. at each level we do a DFS. as we go up the parent chain, we only check the elements before or after the current element.

This reduces element comparison times significantly.

In the old way, if you were on the last page of a link, you'd have to go through pretty much every element in the page. now, it's just a few elements.

[chris fleizach]

Created attachment 115858 [details]
patch

[Beth Dakin]

Comment on attachment 115858 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115858&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:373
> +    for (size_t i = startIndex; isForward ? i > endIndex : i < endIndex; isForward ? i-- : i++) {

This line is hard to read with all of the isForward craziness. I can't think of any obvious way to simplify it, but if you can, I encourage it.

[chris fleizach]

http://trac.webkit.org/changeset/101570