Bug 72516 - [CMake] Make CODE_GENERATOR_PREPROCESSOR more useable
Summary: [CMake] Make CODE_GENERATOR_PREPROCESSOR more useable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-16 09:50 PST by Patrick R. Gansterer
Modified: 2011-11-17 13:47 PST (History)
1 user (show)

See Also:

Attachments
Patch (1.55 KB, patch)
2011-11-16 09:53 PST, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2011-11-16 09:50:03 PST 
[CMake] Make CODE_GENERATOR_PREPROCESSOR more useable
Comment 1 Patrick R. Gansterer 2011-11-16 09:53:04 PST 
Created attachment 115398 [details]
Patch
Comment 2 Brent Fulgham 2011-11-17 11:54:04 PST 
Comment on attachment 115398 [details]
Patch

Using only the executable name implies that the development tools path is in the current environment. This is probably a safe assumption for anything driven by Visual Studio, but will CMake know where to find everything?
Comment 3 Patrick R. Gansterer 2011-11-17 11:55:52 PST 
(In reply to comment #2)
> (From update of attachment 115398 [details])
> Using only the executable name implies that the development tools path is in the current environment. This is probably a safe assumption for anything driven by Visual Studio, but will CMake know where to find everything?

You need a VS environment anyway (at the moment) when building from command line, so it's there safe too.
Comment 4 Brent Fulgham 2011-11-17 12:04:41 PST 
Comment on attachment 115398 [details]
Patch

This change looks good to me!
Comment 5 WebKit Review Bot 2011-11-17 13:47:37 PST 
Comment on attachment 115398 [details]
Patch

Clearing flags on attachment: 115398

Committed r100665: <http://trac.webkit.org/changeset/100665>
Comment 6 WebKit Review Bot 2011-11-17 13:47:41 PST 
All reviewed patches have been landed.  Closing bug.