RESOLVED FIXED 72516
[CMake] Make CODE_GENERATOR_PREPROCESSOR more useable 
https://bugs.webkit.org/show_bug.cgi?id=72516
Summary [CMake] Make CODE_GENERATOR_PREPROCESSOR more useable
Patrick R. Gansterer
Reported 2011-11-16 09:50:03 PST
[CMake] Make CODE_GENERATOR_PREPROCESSOR more useable
Attachments
Patch (1.55 KB, patch)
2011-11-16 09:53 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-11-16 09:53:04 PST
Created attachment 115398 [details] Patch
Brent Fulgham
Comment 2 2011-11-17 11:54:04 PST
Comment on attachment 115398 [details] Patch Using only the executable name implies that the development tools path is in the current environment. This is probably a safe assumption for anything driven by Visual Studio, but will CMake know where to find everything?
Patrick R. Gansterer
Comment 3 2011-11-17 11:55:52 PST
(In reply to comment #2) > (From update of attachment 115398 [details]) > Using only the executable name implies that the development tools path is in the current environment. This is probably a safe assumption for anything driven by Visual Studio, but will CMake know where to find everything? You need a VS environment anyway (at the moment) when building from command line, so it's there safe too.
Brent Fulgham
Comment 4 2011-11-17 12:04:41 PST
Comment on attachment 115398 [details] Patch This change looks good to me!
WebKit Review Bot
Comment 5 2011-11-17 13:47:37 PST
Comment on attachment 115398 [details] Patch Clearing flags on attachment: 115398 Committed r100665: <http://trac.webkit.org/changeset/100665>
WebKit Review Bot
Comment 6 2011-11-17 13:47:41 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.