Bug 72503 - Cleanup: Consolidate the many copies of Ahem in our tests
Summary: Cleanup: Consolidate the many copies of Ahem in our tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-16 07:46 PST by Philip Rogers
Modified: 2011-11-21 09:55 PST (History)
5 users (show)

See Also:


Attachments
First pass at cleaning up the many copies of Ahem (89.42 KB, patch)
2011-11-16 07:50 PST, Philip Rogers
no flags Details | Formatted Diff | Diff
Second pass at cleaning up the many copies of Ahem (30.86 KB, patch)
2011-11-16 18:02 PST, Philip Rogers
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Rogers 2011-11-16 07:46:28 PST
There are now 5 separate copies of Ahem in our tests and we should clean this up.
Comment 1 Philip Rogers 2011-11-16 07:50:53 PST
Created attachment 115378 [details]
First pass at cleaning up the many copies of Ahem
Comment 2 Philip Rogers 2011-11-16 18:02:28 PST
Created attachment 115498 [details]
Second pass at cleaning up the many copies of Ahem

The previous patch failed to apply due to incorrect mime-types on some of the Ahem files, causing them to be treated as plaintext in the patch. I've manually edited the patch and confirmed svn-apply can apply it cleanly now.
Comment 3 Andreas Kling 2011-11-21 07:44:48 PST
Comment on attachment 115498 [details]
Second pass at cleaning up the many copies of Ahem

Great idea! rs=me
Comment 4 WebKit Review Bot 2011-11-21 09:55:23 PST
Comment on attachment 115498 [details]
Second pass at cleaning up the many copies of Ahem

Clearing flags on attachment: 115498

Committed r100930: <http://trac.webkit.org/changeset/100930>
Comment 5 WebKit Review Bot 2011-11-21 09:55:29 PST
All reviewed patches have been landed.  Closing bug.