Bug 72500 - [GTK] Use a URI instead of local path to create download destination in WebKit2
Summary: [GTK] Use a URI instead of local path to create download destination in WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2011-11-16 06:38 PST by Carlos Garcia Campos
Modified: 2011-11-16 23:59 PST (History)
1 user (show)

See Also:


Attachments
Patch (2.00 KB, patch)
2011-11-16 06:41 PST, Carlos Garcia Campos
pnormand: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2011-11-16 06:38:43 PST
We should expect a URI instead of a local path for the destination.
Comment 1 Carlos Garcia Campos 2011-11-16 06:41:56 PST
Created attachment 115371 [details]
Patch
Comment 2 Philippe Normand 2011-11-16 06:47:14 PST
Comment on attachment 115371 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115371&action=review

Looks good! Maybe consider the following nit :)

> Source/WebKit2/WebProcess/Downloads/soup/DownloadSoup.cpp:69
> +            downloadFailed(downloadDestinationError(response, _("Cannot determine destination URI")));

What about mentioning the value of the suggestedFilename?
Comment 3 Martin Robinson 2011-11-16 08:51:20 PST
Comment on attachment 115371 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115371&action=review

>> Source/WebKit2/WebProcess/Downloads/soup/DownloadSoup.cpp:69

> 
> What about mentioning the value of the suggestedFilename?

I think this is a good idea! _ seems to accept standard printf format parameters.
Comment 4 Carlos Garcia Campos 2011-11-16 23:59:22 PST
Committed r100569: <http://trac.webkit.org/changeset/100569>