We should expect a URI instead of a local path for the destination.
Created attachment 115371 [details] Patch
Comment on attachment 115371 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115371&action=review Looks good! Maybe consider the following nit :) > Source/WebKit2/WebProcess/Downloads/soup/DownloadSoup.cpp:69 > + downloadFailed(downloadDestinationError(response, _("Cannot determine destination URI"))); What about mentioning the value of the suggestedFilename?
Comment on attachment 115371 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115371&action=review >> Source/WebKit2/WebProcess/Downloads/soup/DownloadSoup.cpp:69 > > What about mentioning the value of the suggestedFilename? I think this is a good idea! _ seems to accept standard printf format parameters.
Committed r100569: <http://trac.webkit.org/changeset/100569>