RESOLVED FIXED72497
GraphicsContextStateSaver's restore() called redundantly in CanvasRenderingContext2D 
https://bugs.webkit.org/show_bug.cgi?id=72497
Summary GraphicsContextStateSaver's restore() called redundantly in CanvasRenderingCo...
Philip Rogers
Reported 2011-11-16 06:25:53 PST
Created attachment 115368 [details] Small patch to remove an extra restore() call. In https://bugs.webkit.org/show_bug.cgi?id=61528, it was pointed out (by Andreas Kling) that GraphicsContextStateSaver.restore() is called twice in CanvasRenderingContext2D::drawTextInternal.
Attachments
Small patch to remove an extra restore() call. (1.34 KB, patch)
2011-11-16 06:25 PST, Philip Rogers 		no flags
DetailsFormatted DiffDiff
Small patch to remove an extra restore() call. (1.34 KB, patch)
2011-11-16 06:32 PST, Philip Rogers 		kling: review+
kling: commit-queue-
DetailsFormatted DiffDiff
Small patch to remove an extra restore() call. (1.31 KB, patch)
2011-11-16 08:41 PST, Philip Rogers 		no flags
DetailsFormatted DiffDiff
Small patch to remove an extra restore() call. (1.31 KB, patch)
2011-11-16 08:47 PST, Philip Rogers 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Philip Rogers
Comment 1 2011-11-16 06:32:06 PST
Created attachment 115369 [details] Small patch to remove an extra restore() call. Still had the old bugid. Updated 61528->72497
Andreas Kling
Comment 2 2011-11-16 08:38:02 PST
Comment on attachment 115369 [details] Small patch to remove an extra restore() call. View in context: https://bugs.webkit.org/attachment.cgi?id=115369&action=review > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) Actually, cq will choke on this line, you need to remove it. :)
Philip Rogers
Comment 3 2011-11-16 08:41:20 PST
Created attachment 115386 [details] Small patch to remove an extra restore() call. Removed line about no new tests.
Philip Rogers
Comment 4 2011-11-16 08:47:20 PST
Created attachment 115387 [details] Small patch to remove an extra restore() call. Manual edit to patch file fail. Lets try this again..
WebKit Review Bot
Comment 5 2011-11-16 11:17:00 PST
Comment on attachment 115387 [details] Small patch to remove an extra restore() call. Clearing flags on attachment: 115387 Committed r100475: <http://trac.webkit.org/changeset/100475>
WebKit Review Bot
Comment 6 2011-11-16 11:17:05 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.