The implementation of style scoped passes the scope to be used for selector matching into the matching functions. matchRules() does not use a scope, so should be renamed to indicate this.
Created attachment 115350 [details]
Comment on attachment 115350 [details]
I suprised scoped matching would use a different matching function on this level. Why? (please cc me to all these)
This feels like a name that could be confusing when you are not actively working on scoped stye code. Perhaps "...InGlobalScope" would be more clear?
Created attachment 115516 [details]
I like matchRulesInGlobalScope()! New patch with this name uploaded.
(In reply to comment #2)
> (From update of attachment 115350 [details])
> I suprised scoped matching would use a different matching function on this level. Why? (please cc me to all these)
matching Author rules will be done both globally and scoped, while other rules are matched globally only. With the rules themselves not carrying the scope, I feel the function name should make it explicit that no scoping will take place.
Comment on attachment 115516 [details]
I added some comments to bug 67720. I'd like to see a more narrowly focused full patch before doing any code changes for this feature.
It's probably better to do the renaming after the functionality has landed, to avoid confusion. Marking this as invalid for now.