Bug 72471 - [chromium] Improvements for page scale delta during commit
Summary: [chromium] Improvements for page scale delta during commit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-15 23:30 PST by Alexandre Elias
Modified: 2011-11-16 14:38 PST (History)
4 users (show)

See Also:


Attachments
Patch (13.31 KB, patch)
2011-11-15 23:43 PST, Alexandre Elias
no flags Details | Formatted Diff | Diff
Patch (21.47 KB, patch)
2011-11-16 12:51 PST, Alexandre Elias
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Elias 2011-11-15 23:30:23 PST
[chromium] Improvements for page scale delta during commit
Comment 1 Alexandre Elias 2011-11-15 23:43:57 PST
Created attachment 115334 [details]
Patch
Comment 2 James Robinson 2011-11-16 00:52:34 PST
Comment on attachment 115334 [details]
Patch

terminology request: we have pageScale and pageScaleDelta in most places but also scaleDelta and sentScaleDelta. Can the latter two please be pageScaleDelta and sentPageScaleDelta?
Comment 3 Alexandre Elias 2011-11-16 12:51:25 PST
Created attachment 115426 [details]
Patch
Comment 4 Alexandre Elias 2011-11-16 12:53:18 PST
OK, renamed to pageScaleDelta everywhere.
Comment 5 James Robinson 2011-11-16 13:40:59 PST
Comment on attachment 115426 [details]
Patch

Looks great, thanks!
Comment 6 WebKit Review Bot 2011-11-16 14:38:10 PST
Comment on attachment 115426 [details]
Patch

Clearing flags on attachment: 115426

Committed r100508: <http://trac.webkit.org/changeset/100508>
Comment 7 WebKit Review Bot 2011-11-16 14:38:15 PST
All reviewed patches have been landed.  Closing bug.