RESOLVED FIXED Bug 72464
[chromium] Add null pointer check in setDeviceScaleFactor 
https://bugs.webkit.org/show_bug.cgi?id=72464
Summary [chromium] Add null pointer check in setDeviceScaleFactor
Alexandre Elias
Reported 2011-11-15 22:44:31 PST
[chromium] Add null pointer check in setDeviceScaleFActor
Attachments
Patch (1.27 KB, patch)
2011-11-15 22:45 PST, Alexandre Elias 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexandre Elias
Comment 1 2011-11-15 22:45:50 PST
Created attachment 115325 [details] Patch
Fady Samuel
Comment 2 2011-11-16 09:59:41 PST
That looks fine to me. Please ask fishd or jamesr to r+ it.
WebKit Review Bot
Comment 3 2011-11-16 13:11:39 PST
Comment on attachment 115325 [details] Patch Clearing flags on attachment: 115325 Committed r100496: <http://trac.webkit.org/changeset/100496>
WebKit Review Bot
Comment 4 2011-11-16 13:11:43 PST
All reviewed patches have been landed. Closing bug.
Adam Roben (:aroben)
Comment 5 2011-11-16 13:13:41 PST
Comment on attachment 115325 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115325&action=review > Source/WebCore/ChangeLog:8 > + No new tests. (Tiny fix.) I don't understand this. Sure, the fix is small in terms of the number of characters changed. But presumably you are fixing a crash, which is not a "tiny" issue. Is it possible to test this?
Note You need to log in before you can comment on or make changes to this bug.