Bug 72464 - [chromium] Add null pointer check in setDeviceScaleFactor
Summary: [chromium] Add null pointer check in setDeviceScaleFactor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-15 22:44 PST by Alexandre Elias
Modified: 2011-11-16 13:13 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.27 KB, patch)
2011-11-15 22:45 PST, Alexandre Elias 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Elias 2011-11-15 22:44:31 PST 
[chromium] Add null pointer check in setDeviceScaleFActor
Comment 1 Alexandre Elias 2011-11-15 22:45:50 PST 
Created attachment 115325 [details]
Patch
Comment 2 Fady Samuel 2011-11-16 09:59:41 PST 
That looks fine to me. Please ask fishd or jamesr to r+ it.
Comment 3 WebKit Review Bot 2011-11-16 13:11:39 PST 
Comment on attachment 115325 [details]
Patch

Clearing flags on attachment: 115325

Committed r100496: <http://trac.webkit.org/changeset/100496>
Comment 4 WebKit Review Bot 2011-11-16 13:11:43 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Adam Roben (:aroben) 2011-11-16 13:13:41 PST 
Comment on attachment 115325 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115325&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests. (Tiny fix.)

I don't understand this. Sure, the fix is small in terms of the number of characters changed. But presumably you are fixing a crash, which is not a "tiny" issue. Is it possible to test this?