Bug 72425 - Clip rects should be in root view coordinates
Summary: Clip rects should be in root view coordinates
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-15 14:36 PST by Anders Carlsson
Modified: 2022-10-05 16:17 PDT (History)
7 users (show)

See Also:

Attachments
Patch (20.98 KB, patch)
2011-11-15 14:41 PST, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (21.38 KB, patch)
2011-11-15 17:25 PST, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-11-15 14:36:48 PST 
Clip rects should be in root view coordinates
Comment 1 Anders Carlsson 2011-11-15 14:41:52 PST 
Created attachment 115251 [details]
Patch
Comment 2 WebKit Review Bot 2011-11-15 15:45:36 PST 
Comment on attachment 115251 [details]
Patch

Attachment 115251 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10483495
Comment 3 Anders Carlsson 2011-11-15 17:25:39 PST 
Created attachment 115285 [details]
Patch
Comment 4 Ahmad Saleem 2022-10-05 16:16:50 PDT 
From Webkit GitHub linkage to attach patch modification:

EmbeddedWidget.cpp is no more.

FrameView.cpp - It is still to Legacy - https://github.com/WebKit/WebKit/blob/71af797599da12fa56a502b6f23501f31e289dc2/Source/WebCore/page/FrameView.cpp#L4063

then there are some Chromium build changes - which are not applicable anymore.

In PluginView.cpp - we still have this (more of renaming it seems in whole patch):

https://github.com/WebKit/WebKit/blob/23e2639c3e05df5f20cb2a3b5411ee5f8b846206/Source/WebKit/WebProcess/Plugins/PluginView.cpp#L659

widgetPositionsUpdated is removed from RenderWidget.cpp:

https://github.com/WebKit/WebKit/commit/a0b9903d75fd1b579789122ffaa728aab69bf016

____

In short summary, do we need this change? Thanks!