Bug 72423 - [Chromium] Crash executing the WebGL conformance tests
Summary: [Chromium] Crash executing the WebGL conformance tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jeff Timanus
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-15 14:30 PST by Jeff Timanus
Modified: 2011-11-15 21:12 PST (History)
6 users (show)

See Also:


Attachments
Patch (1.87 KB, patch)
2011-11-15 14:33 PST, Jeff Timanus
no flags Details | Formatted Diff | Diff
Patch (2.05 KB, patch)
2011-11-15 16:25 PST, Jeff Timanus
no flags Details | Formatted Diff | Diff
Patch (2.05 KB, patch)
2011-11-15 16:33 PST, Jeff Timanus
no flags Details | Formatted Diff | Diff
Patch (2.03 KB, patch)
2011-11-15 16:47 PST, Jeff Timanus
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Timanus 2011-11-15 14:30:16 PST
During WebGLRenderingContext tear down, the WebGLLayerChromium is attempting to stop a timer for a NULL context.

See chromium tracking issue here:  crbug.com\104367
Comment 1 Jeff Timanus 2011-11-15 14:33:06 PST
Created attachment 115248 [details]
Patch
Comment 2 Jeff Timanus 2011-11-15 16:25:11 PST
Created attachment 115273 [details]
Patch
Comment 3 Jeff Timanus 2011-11-15 16:33:30 PST
Created attachment 115276 [details]
Patch
Comment 4 Kenneth Russell 2011-11-15 16:41:37 PST
Comment on attachment 115276 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115276&action=review

Looks good to me; minor comment nit. Could you upload a final patch? Also, did you get an email about what the style failure is? (Did you upload with webkit-patch upload? That checks style before uploading.)

> Source/WebCore/ChangeLog:4
> +        [chromium] During tear down, prevent the WebGLLayerChromium instance
> +        from attempting to stop a timer for a NULL context.

Does this need to be one line?

> Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.cpp:131
> +    // The GraphicsContext3D used by the layer is the context associated with
> +    // with the drawing buffer. If the drawing buffer is changing, make sure

with with -> with
Comment 5 Jeff Timanus 2011-11-15 16:47:37 PST
Created attachment 115281 [details]
Patch
Comment 6 Jeff Timanus 2011-11-15 16:48:38 PST
Comment on attachment 115276 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115276&action=review

>> Source/WebCore/ChangeLog:4
>> +        from attempting to stop a timer for a NULL context.
> 
> Does this need to be one line?

Done.

>> Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.cpp:131
>> +    // with the drawing buffer. If the drawing buffer is changing, make sure
> 
> with with -> with

Thanks for catching that.

Done.
Comment 7 Jeff Timanus 2011-11-15 16:51:54 PST
(In reply to comment #4)
> (From update of attachment 115276 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=115276&action=review
> 
> Looks good to me; minor comment nit. Could you upload a final patch? Also, did you get an email about what the style failure is? (Did you upload with webkit-patch upload? That checks style before uploading.)

Yes, I used webkit-patch upload to upload all of these patches.  I also ran check-webkit-style before uploading.  It reported no errors.  I have yet to receive the style failure notification, so I'm not sure what is up.

Fortunately, the most recent patch seems to be passing the style check.

> 
> > Source/WebCore/ChangeLog:4
> > +        [chromium] During tear down, prevent the WebGLLayerChromium instance
> > +        from attempting to stop a timer for a NULL context.
> 
> Does this need to be one line?
> 
> > Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.cpp:131
> > +    // The GraphicsContext3D used by the layer is the context associated with
> > +    // with the drawing buffer. If the drawing buffer is changing, make sure
> 
> with with -> with
Comment 8 Kenneth Russell 2011-11-15 19:57:11 PST
Comment on attachment 115281 [details]
Patch

Looks good. r=me
Comment 9 WebKit Review Bot 2011-11-15 21:12:47 PST
Comment on attachment 115281 [details]
Patch

Clearing flags on attachment: 115281

Committed r100401: <http://trac.webkit.org/changeset/100401>
Comment 10 WebKit Review Bot 2011-11-15 21:12:52 PST
All reviewed patches have been landed.  Closing bug.