Add WebKit2 API object to represent a connection
Created attachment 115246 [details] Patch
Comment on attachment 115246 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115246&action=review > Source/WebKit2/Shared/WebConnection.cpp:38 > + Extra newline
Attachment 115246 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/Shared/API/c/WKConnectionRef.cpp:30: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/Shared/WebConnectionClient.cpp:31: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r100336: <http://trac.webkit.org/changeset/100336>
It broke all layout tests on the Qt-WK2 platform.
(In reply to comment #5) > It broke all layout tests on the Qt-WK2 platform. That's odd, given that the patch only adds new code that isn't used currently.
(In reply to comment #6) > (In reply to comment #5) > > It broke all layout tests on the Qt-WK2 platform. > > That's odd, given that the patch only adds new code that isn't used currently. r100331 was good, r100337 was bad. Let's check these revisions: - r100332 modified safari-534.53-branch - r100333 modified chromium test expectations - r100334 modified safari-534.53-branch - r100335 modified safari-534.53-branch - r100336 modified WK2 code - r100337 modified chromium test expectations So I am absolutely convinced that r100336 is the culprit revision.
(In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #5) > > > It broke all layout tests on the Qt-WK2 platform. > > > > That's odd, given that the patch only adds new code that isn't used currently. > > r100331 was good, r100337 was bad. Let's check these revisions: > - r100332 modified safari-534.53-branch > - r100333 modified chromium test expectations > - r100334 modified safari-534.53-branch > - r100335 modified safari-534.53-branch > - r100336 modified WK2 code > - r100337 modified chromium test expectations > > So I am absolutely convinced that r100336 is the culprit revision. Unless touching of the .pro file caused a re-run of qmake, triggering previously broken dependencies. I'll take a look at the failures.
(In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > (In reply to comment #5) > > > > It broke all layout tests on the Qt-WK2 platform. > > > > > > That's odd, given that the patch only adds new code that isn't used currently. > > > > r100331 was good, r100337 was bad. Let's check these revisions: > > - r100332 modified safari-534.53-branch > > - r100333 modified chromium test expectations > > - r100334 modified safari-534.53-branch > > - r100335 modified safari-534.53-branch > > - r100336 modified WK2 code > > - r100337 modified chromium test expectations > > > > So I am absolutely convinced that r100336 is the culprit revision. > > Unless touching of the .pro file caused a re-run of qmake, triggering previously broken dependencies. I'll take a look at the failures. Went back to r100333, did a clean build and still get the WTR timeouts. So it's definitely not this change that broke it.