Bug 72421 - Add WebKit2 API object to represent a connection
Summary: Add WebKit2 API object to represent a connection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-15 14:23 PST by Sam Weinig
Modified: 2011-11-16 01:02 PST (History)
7 users (show)

See Also:


Attachments
Patch (29.43 KB, patch)
2011-11-15 14:26 PST, Sam Weinig
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-11-15 14:23:31 PST
Add WebKit2 API object to represent a connection
Comment 1 Sam Weinig 2011-11-15 14:26:45 PST
Created attachment 115246 [details]
Patch
Comment 2 Anders Carlsson 2011-11-15 14:28:09 PST
Comment on attachment 115246 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115246&action=review

> Source/WebKit2/Shared/WebConnection.cpp:38
> +

Extra newline
Comment 3 WebKit Review Bot 2011-11-15 14:30:45 PST
Attachment 115246 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/Shared/API/c/WKConnectionRef.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit2/Shared/WebConnectionClient.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Sam Weinig 2011-11-15 15:01:14 PST
Committed r100336: <http://trac.webkit.org/changeset/100336>
Comment 5 Csaba Osztrogonác 2011-11-15 23:30:26 PST
It broke all layout tests on the Qt-WK2 platform.
Comment 6 Simon Hausmann 2011-11-16 00:16:31 PST
(In reply to comment #5)
> It broke all layout tests on the Qt-WK2 platform.

That's odd, given that the patch only adds new code that isn't used currently.
Comment 7 Csaba Osztrogonác 2011-11-16 00:27:12 PST
(In reply to comment #6)
> (In reply to comment #5)
> > It broke all layout tests on the Qt-WK2 platform.
> 
> That's odd, given that the patch only adds new code that isn't used currently.

r100331 was good, r100337 was bad. Let's check these revisions:
- r100332 modified safari-534.53-branch
- r100333 modified chromium test expectations
- r100334 modified safari-534.53-branch
- r100335 modified safari-534.53-branch
- r100336 modified WK2 code
- r100337 modified chromium test expectations

So I am absolutely convinced that r100336 is the culprit revision.
Comment 8 Simon Hausmann 2011-11-16 00:33:30 PST
(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > It broke all layout tests on the Qt-WK2 platform.
> > 
> > That's odd, given that the patch only adds new code that isn't used currently.
> 
> r100331 was good, r100337 was bad. Let's check these revisions:
> - r100332 modified safari-534.53-branch
> - r100333 modified chromium test expectations
> - r100334 modified safari-534.53-branch
> - r100335 modified safari-534.53-branch
> - r100336 modified WK2 code
> - r100337 modified chromium test expectations
> 
> So I am absolutely convinced that r100336 is the culprit revision.

Unless touching of the .pro file caused a re-run of qmake, triggering previously broken dependencies. I'll take a look at the failures.
Comment 9 Simon Hausmann 2011-11-16 01:02:58 PST
(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > (In reply to comment #5)
> > > > It broke all layout tests on the Qt-WK2 platform.
> > > 
> > > That's odd, given that the patch only adds new code that isn't used currently.
> > 
> > r100331 was good, r100337 was bad. Let's check these revisions:
> > - r100332 modified safari-534.53-branch
> > - r100333 modified chromium test expectations
> > - r100334 modified safari-534.53-branch
> > - r100335 modified safari-534.53-branch
> > - r100336 modified WK2 code
> > - r100337 modified chromium test expectations
> > 
> > So I am absolutely convinced that r100336 is the culprit revision.
> 
> Unless touching of the .pro file caused a re-run of qmake, triggering previously broken dependencies. I'll take a look at the failures.

Went back to r100333, did a clean build and still get the WTR timeouts. So it's definitely not this change that broke it.