RESOLVED FIXED 72421
Add WebKit2 API object to represent a connection
https://bugs.webkit.org/show_bug.cgi?id=72421
Summary Add WebKit2 API object to represent a connection
Sam Weinig
Reported 2011-11-15 14:23:31 PST
Add WebKit2 API object to represent a connection
Attachments
Patch (29.43 KB, patch)
2011-11-15 14:26 PST, Sam Weinig
andersca: review+
Sam Weinig
Comment 1 2011-11-15 14:26:45 PST
Anders Carlsson
Comment 2 2011-11-15 14:28:09 PST
Comment on attachment 115246 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115246&action=review > Source/WebKit2/Shared/WebConnection.cpp:38 > + Extra newline
WebKit Review Bot
Comment 3 2011-11-15 14:30:45 PST
Attachment 115246 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/Shared/API/c/WKConnectionRef.cpp:30: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/Shared/WebConnectionClient.cpp:31: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 4 2011-11-15 15:01:14 PST
Csaba Osztrogonác
Comment 5 2011-11-15 23:30:26 PST
It broke all layout tests on the Qt-WK2 platform.
Simon Hausmann
Comment 6 2011-11-16 00:16:31 PST
(In reply to comment #5) > It broke all layout tests on the Qt-WK2 platform. That's odd, given that the patch only adds new code that isn't used currently.
Csaba Osztrogonác
Comment 7 2011-11-16 00:27:12 PST
(In reply to comment #6) > (In reply to comment #5) > > It broke all layout tests on the Qt-WK2 platform. > > That's odd, given that the patch only adds new code that isn't used currently. r100331 was good, r100337 was bad. Let's check these revisions: - r100332 modified safari-534.53-branch - r100333 modified chromium test expectations - r100334 modified safari-534.53-branch - r100335 modified safari-534.53-branch - r100336 modified WK2 code - r100337 modified chromium test expectations So I am absolutely convinced that r100336 is the culprit revision.
Simon Hausmann
Comment 8 2011-11-16 00:33:30 PST
(In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #5) > > > It broke all layout tests on the Qt-WK2 platform. > > > > That's odd, given that the patch only adds new code that isn't used currently. > > r100331 was good, r100337 was bad. Let's check these revisions: > - r100332 modified safari-534.53-branch > - r100333 modified chromium test expectations > - r100334 modified safari-534.53-branch > - r100335 modified safari-534.53-branch > - r100336 modified WK2 code > - r100337 modified chromium test expectations > > So I am absolutely convinced that r100336 is the culprit revision. Unless touching of the .pro file caused a re-run of qmake, triggering previously broken dependencies. I'll take a look at the failures.
Simon Hausmann
Comment 9 2011-11-16 01:02:58 PST
(In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > (In reply to comment #5) > > > > It broke all layout tests on the Qt-WK2 platform. > > > > > > That's odd, given that the patch only adds new code that isn't used currently. > > > > r100331 was good, r100337 was bad. Let's check these revisions: > > - r100332 modified safari-534.53-branch > > - r100333 modified chromium test expectations > > - r100334 modified safari-534.53-branch > > - r100335 modified safari-534.53-branch > > - r100336 modified WK2 code > > - r100337 modified chromium test expectations > > > > So I am absolutely convinced that r100336 is the culprit revision. > > Unless touching of the .pro file caused a re-run of qmake, triggering previously broken dependencies. I'll take a look at the failures. Went back to r100333, did a clean build and still get the WTR timeouts. So it's definitely not this change that broke it.
Note You need to log in before you can comment on or make changes to this bug.