Bug 72393 – Web Inspector: introduce Debugger domain capabilities concept.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Many of the Preferences that we have in Settings.js and override in DevTools.js are really not preferences, but capabilities. Protocol clients should have a way of figuring out whether some capability is present before using it. I'm adding the "capability" concept into the JSON and Debugger::getCapabilities as the first implementation. Marked as hidden so far.

[Pavel Feldman]

Created attachment 115185 [details]
Patch

[WebKit Review Bot]

Attachment 115185 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/inspector/InspectorDebuggerAgent.cpp:103:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorDebuggerAgent.h:67:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yury Semikhatsky]

Comment on attachment 115185 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115185&action=review

> Source/WebCore/bindings/v8/ScriptDebugServer.cpp:43
> +#include <wtf/Vector.h>

remove this

> Source/WebCore/bindings/v8/ScriptDebugServer.h:44
> +#include <wtf/Vector.h>

remove this

> Source/WebCore/inspector/Inspector.json:1797
> +                "name": "getCapabilities",

Should we have a separate command getCapabilities([domain]) instead of introducing it on each agent?

[Pavel Feldman]

Committed r100572: <http://trac.webkit.org/changeset/100572>

[Peter Kasting]

This may have caused bug 72651.  I'm going to try rolling out r100572 to see if the Linux dbg bot stabilizes.

[Peter Kasting]

The rollout did not help, so I'm rolling this change back in.