Bug 72389 - [Qt][WK2][Mac] MiniBrowser cannot create socketpair.
Summary: [Qt][WK2][Mac] MiniBrowser cannot create socketpair.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zeno Albisser
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-15 08:33 PST by Zeno Albisser
Modified: 2011-11-16 06:56 PST (History)
2 users (show)

See Also:

Attachments
patch for review. (1.10 KB, patch)
2011-11-15 09:24 PST, Zeno Albisser 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zeno Albisser 2011-11-15 08:33:51 PST 
Creation of socket failed with errno: 43

This is due to using AF_UNIX and SOCK_SEQPACKET in socketpair.
This is fine for Linux, but seems not to be implemented on mac.
We should simply go back to using SOCK_DGRAM for mac.
Comment 1 Zeno Albisser 2011-11-15 09:24:25 PST 
Created attachment 115178 [details]
patch for review.
Comment 2 Zeno Albisser 2011-11-16 02:40:05 PST 
we should consider replacing our IPC mechanisms with the webkit2 ones from the mac port.
i will see if this is doable, and come up with a patch for that.
Comment 3 Zeno Albisser 2011-11-16 05:48:12 PST 
Comment on attachment 115178 [details]
patch for review.

lets have this as an intermediate fix for the mac platform.
Nevertheless I will be glad to look into a longterm solution of course. :)
Comment 4 Zeno Albisser 2011-11-16 06:56:22 PST 
Comment on attachment 115178 [details]
patch for review.

Clearing flags on attachment: 115178

Committed r100445: <http://trac.webkit.org/changeset/100445>
Comment 5 Zeno Albisser 2011-11-16 06:56:31 PST 
All reviewed patches have been landed.  Closing bug.