Bug 72386 - Recent svg/foreignObject tests failing on Mac & Win
Summary: Recent svg/foreignObject tests failing on Mac & Win
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-15 07:41 PST by Florin Malita
Modified: 2011-11-16 10:16 PST (History)
4 users (show)

See Also:

Attachments
Patch (6.95 KB, patch)
2011-11-15 07:44 PST, Florin Malita 		no flags Details | Formatted Diff | Diff
Patch (13.33 KB, patch)
2011-11-15 08:02 PST, Florin Malita 		no flags Details | Formatted Diff | Diff
Patch (12.46 KB, patch)
2011-11-15 09:15 PST, Florin Malita 		no flags Details | Formatted Diff | Diff
Patch (36.14 KB, patch)
2011-11-15 13:21 PST, Florin Malita 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Florin Malita 2011-11-15 07:41:43 PST 
SVG tests introduced in r100157, r100045 & r99862 are failing on SnowLeopard, Lion. Incoming patch.

--- /Volumes/Data/slave/lion-intel-debug-tests/build/layout-test-results/svg/foreignObject/background-render-phase-expected.txt
+++ /Volumes/Data/slave/lion-intel-debug-tests/build/layout-test-results/svg/foreignObject/background-render-phase-actual.txt
@@ -7,6 +7,6 @@
         RenderSVGPath {rect} at (0,0) size 100x50 [fill={[type=SOLID] [color=#FF0000]}] [x=0.00] [y=0.00] [width=100.00] [height=50.00]
         RenderSVGForeignObject {foreignObject} at (0,0) size 200x50
           RenderBlock {DIV} at (0,0) size 200x50 [bgcolor=#008000]
-            RenderText {#text} at (0,0) size 4x19
+            RenderText {#text} at (0,0) size 4x18
               text run at (0,0) width 4: " "
       RenderText {#text} at (0,0) size 0x0


--- /Volumes/Data/slave/lion-intel-debug-tests/build/layout-test-results/svg/foreignObject/clip-expected.txt
+++ /Volumes/Data/slave/lion-intel-debug-tests/build/layout-test-results/svg/foreignObject/clip-actual.txt
@@ -9,9 +9,9 @@
             RenderSVGPath {rect} at (0,0) size 200x50 [fill={[type=SOLID] [color=#000000]}] [x=0.00] [y=0.00] [width=200.00] [height=50.00]
         RenderSVGForeignObject {foreignObject} at (0,0) size 200x100
           RenderBlock {DIV} at (0,0) size 200x50 [bgcolor=#00FF00]
-            RenderText {#text} at (0,0) size 4x19
+            RenderText {#text} at (0,0) size 4x18
               text run at (0,0) width 4: " "
           RenderBlock {DIV} at (0,50) size 200x50 [bgcolor=#FF0000]
-            RenderText {#text} at (0,0) size 4x19
+            RenderText {#text} at (0,0) size 4x18
               text run at (0,0) width 4: " "
       RenderText {#text} at (0,0) size 0x0


--- /Volumes/Data/slave/lion-intel-debug-tests/build/layout-test-results/svg/foreignObject/filter-expected.txt
+++ /Volumes/Data/slave/lion-intel-debug-tests/build/layout-test-results/svg/foreignObject/filter-actual.txt
@@ -10,9 +10,9 @@
               [SourceGraphic]
         RenderSVGForeignObject {foreignObject} at (0,0) size 200x100
           RenderBlock {DIV} at (0,0) size 200x50 [bgcolor=#00FF00]
-            RenderText {#text} at (0,0) size 4x19
+            RenderText {#text} at (0,0) size 4x18
               text run at (0,0) width 4: " "
           RenderBlock {DIV} at (0,50) size 200x50 [bgcolor=#FF0000]
-            RenderText {#text} at (0,0) size 4x19
+            RenderText {#text} at (0,0) size 4x18
               text run at (0,0) width 4: " "
       RenderText {#text} at (0,0) size 0x0


--- /Volumes/Data/slave/lion-intel-debug-tests/build/layout-test-results/svg/foreignObject/mask-expected.txt
+++ /Volumes/Data/slave/lion-intel-debug-tests/build/layout-test-results/svg/foreignObject/mask-actual.txt
@@ -9,9 +9,9 @@
             RenderSVGPath {rect} at (0,0) size 200x50 [fill={[type=SOLID] [color=#FFFFFF]}] [x=0.00] [y=0.00] [width=200.00] [height=50.00]
         RenderSVGForeignObject {foreignObject} at (0,0) size 200x100
           RenderBlock {DIV} at (0,0) size 200x50 [bgcolor=#00FF00]
-            RenderText {#text} at (0,0) size 4x19
+            RenderText {#text} at (0,0) size 4x18
               text run at (0,0) width 4: " "
           RenderBlock {DIV} at (0,50) size 200x50 [bgcolor=#FF0000]
-            RenderText {#text} at (0,0) size 4x19
+            RenderText {#text} at (0,0) size 4x18
               text run at (0,0) width 4: " "
       RenderText {#text} at (0,0) size 0x0


--- /Volumes/Data/slave/lion-intel-debug-tests/build/layout-test-results/svg/foreignObject/multiple-foreign-objects-expected.txt
+++ /Volumes/Data/slave/lion-intel-debug-tests/build/layout-test-results/svg/foreignObject/multiple-foreign-objects-actual.txt
@@ -6,7 +6,7 @@
       RenderSVGRoot {svg} at (0,0) size 400x100
         RenderSVGForeignObject {foreignObject} at (0,0) size 100x100
           RenderBlock {DIV} at (0,0) size 100x100 [bgcolor=#008000]
-            RenderText {#text} at (0,0) size 4x19
+            RenderText {#text} at (0,0) size 4x18
               text run at (0,0) width 4: " "
         RenderSVGForeignObject {foreignObject} at (150,0) size 100x100
           RenderBlock {DIV} at (0,0) size 100x100 [bgcolor=#008000]
Comment 1 Florin Malita 2011-11-15 07:44:12 PST 
Created attachment 115164 [details]
Patch
Comment 2 Florin Malita 2011-11-15 08:00:58 PST 
Looks like Win also needs platform specific results.
Comment 3 Florin Malita 2011-11-15 08:02:02 PST 
Created attachment 115166 [details]
Patch
Comment 4 WebKit Review Bot 2011-11-15 08:34:51 PST 
Comment on attachment 115166 [details]
Patch

Attachment 115166 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10484377

New failing tests:
svg/foreignObject/multiple-foreign-objects.html
Comment 5 Florin Malita 2011-11-15 09:15:33 PST 
Created attachment 115177 [details]
Patch
Comment 6 Florin Malita 2011-11-15 12:18:57 PST 
Comment on attachment 115177 [details]
Patch

I think there's a better way to handle this: avoid the sized text elements altogether. Then font size variation across platforms is no longer an issue.
Comment 7 Florin Malita 2011-11-15 13:21:39 PST 
Created attachment 115226 [details]
Patch
Comment 8 WebKit Review Bot 2011-11-16 10:16:20 PST 
Comment on attachment 115226 [details]
Patch

Clearing flags on attachment: 115226

Committed r100465: <http://trac.webkit.org/changeset/100465>
Comment 9 WebKit Review Bot 2011-11-16 10:16:25 PST 
All reviewed patches have been landed.  Closing bug.