Bug 72385 - Explicitly include unistd.h in TestNetscapePlugIn
Summary: Explicitly include unistd.h in TestNetscapePlugIn
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peter Beverloo
URL:
Keywords:
Depends on:
Blocks: 66689
  Show dependency treegraph
 
Reported: 2011-11-15 07:14 PST by Peter Beverloo
Modified: 2011-11-16 04:52 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.13 KB, patch)
2011-11-15 07:15 PST, Peter Beverloo
no flags Details | Formatted Diff | Diff
Patch (1.22 KB, patch)
2011-11-16 04:36 PST, Peter Beverloo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Beverloo 2011-11-15 07:14:38 PST
Minor change; this is needed for the sleep() call in the indicateTestFailure method, which seems to be implicitly available for other platforms. This is not the case on Android.
Comment 1 Peter Beverloo 2011-11-15 07:15:16 PST
Created attachment 115162 [details]
Patch
Comment 2 Steve Block 2011-11-15 09:31:48 PST
Comment on attachment 115162 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115162&action=review

> Tools/DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:32
> +#if defined(OS_ANDROID)

#if OS(ANDROID)
Comment 3 Peter Beverloo 2011-11-15 09:42:44 PST
(In reply to comment #2)
> (From update of attachment 115162 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=115162&action=review
> 
> > Tools/DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:32
> > +#if defined(OS_ANDROID)
> 
> #if OS(ANDROID)

WTF is not available in TestNetscapePlugIn, including Platform.h which defines the OS() shorthand. In fact, I think we should be checking for defined(ANDROID) as even OS_ANDROID may not be available.
Comment 4 Peter Beverloo 2011-11-15 09:48:32 PST
To emphasize, the patch works just fine, but I'm not sure why OS_ANDROID is available. I'll investigate that prior to uploading a second patch (if needed).
Comment 5 Peter Beverloo 2011-11-16 04:36:03 PST
Created attachment 115357 [details]
Patch

Updated patch. OS_ANDROID is being defined in Source/WebKit/chromium/build/build_config.h whereas ANDROID is defined for all projects, so I prefer the latter.
Comment 6 WebKit Review Bot 2011-11-16 04:52:21 PST
Comment on attachment 115357 [details]
Patch

Clearing flags on attachment: 115357

Committed r100432: <http://trac.webkit.org/changeset/100432>
Comment 7 WebKit Review Bot 2011-11-16 04:52:25 PST
All reviewed patches have been landed.  Closing bug.