Minor change; this is needed for the sleep() call in the indicateTestFailure method, which seems to be implicitly available for other platforms. This is not the case on Android.
Created attachment 115162 [details] Patch
Comment on attachment 115162 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115162&action=review > Tools/DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:32 > +#if defined(OS_ANDROID) #if OS(ANDROID)
(In reply to comment #2) > (From update of attachment 115162 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=115162&action=review > > > Tools/DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:32 > > +#if defined(OS_ANDROID) > > #if OS(ANDROID) WTF is not available in TestNetscapePlugIn, including Platform.h which defines the OS() shorthand. In fact, I think we should be checking for defined(ANDROID) as even OS_ANDROID may not be available.
To emphasize, the patch works just fine, but I'm not sure why OS_ANDROID is available. I'll investigate that prior to uploading a second patch (if needed).
Created attachment 115357 [details] Patch Updated patch. OS_ANDROID is being defined in Source/WebKit/chromium/build/build_config.h whereas ANDROID is defined for all projects, so I prefer the latter.
Comment on attachment 115357 [details] Patch Clearing flags on attachment: 115357 Committed r100432: <http://trac.webkit.org/changeset/100432>
All reviewed patches have been landed. Closing bug.