Bug 72381 - media-blocked-by-willsendrequest.html is flaky
Summary: media-blocked-by-willsendrequest.html is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-15 05:56 PST by Tony Gentilcore
Modified: 2011-11-15 08:15 PST (History)
1 user (show)

See Also:


Attachments
Patch (1.25 KB, patch)
2011-11-15 06:43 PST, Tony Gentilcore
no flags Details | Formatted Diff | Diff
Proposed patch (2.65 KB, patch)
2011-11-15 07:45 PST, Eric Carlson
tonyg: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Gentilcore 2011-11-15 05:56:56 PST
The media/media-blocked-by-willsendrequest.html test has been flaky across all chromium platforms for as far back as we have history. My guess is that the flakiness isn't limited to chromium, though. When the test fails, we are missing the following two lines of output:
EVENT(loadstart)
EVENT(error)

From the symptoms, my best guess is that the test is trying to run before the video's loadstart. 

Eric, assigning to you just because you are the test author and I don't want to leave this ownerless. Please feel free re-title if this is chromium specific and/or bounce back to me for any reason.

Chromium flakiness dashboard results:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=media%2Fmedia-blocked-by-willsendrequest.html
Comment 1 Tony Gentilcore 2011-11-15 06:43:15 PST
Created attachment 115154 [details]
Patch
Comment 2 Tony Gentilcore 2011-11-15 06:43:53 PST
Committed r100275: <http://trac.webkit.org/changeset/100275>
Comment 3 Eric Carlson 2011-11-15 07:20:12 PST
(In reply to comment #0)
> The media/media-blocked-by-willsendrequest.html test has been flaky across all chromium platforms for as far back as we have history. My guess is that the flakiness isn't limited to chromium, though. When the test fails, we are missing the following two lines of output:
> EVENT(loadstart)
> EVENT(error)
> 
> From the symptoms, my best guess is that the test is trying to run before the video's loadstart. 
> 
I think your guess is correct. I believe that the test passes on other platforms but fails on chromium because the chromium media engine takes longer to start up so the widow's 'load' event is fired while the media events are in the queue waiting to be dispatched.

> Eric, assigning to you just because you are the test author and I don't want to leave this ownerless. 
>
I will change the test to not finish until all required events have been handled.
Comment 4 Eric Carlson 2011-11-15 07:45:48 PST
Created attachment 115165 [details]
Proposed patch
Comment 5 Tony Gentilcore 2011-11-15 07:56:52 PST
Comment on attachment 115165 [details]
Proposed patch

Thanks! Any chance I could talk you into reverting r100275 along with this patch?
Comment 6 Eric Carlson 2011-11-15 08:15:25 PST
(In reply to comment #5)
> (From update of attachment 115165 [details])
> Thanks! Any chance I could talk you into reverting r100275 along with this patch?

Good point, will do.
Comment 7 Eric Carlson 2011-11-15 08:15:34 PST
http://trac.webkit.org/changeset/100282