Bug 72380 – [GTK] Add webkit_web_view_load_request() to WebKit2 GTK+ API

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Carlos Garcia Campos]

We need to add WebKitNetworkRequest too.

[Carlos Garcia Campos]

Created attachment 115146 [details]
Patch

[WebKit Review Bot]

Attachment 115146 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

WARNING: File exempt from style guide. Skipping: "Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h"
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/UIProcess/API/gtk/WebKitNetworkRequest.h"
Source/WebKit2/UIProcess/API/gtk/WebKitNetworkRequest.cpp:92:  Use 0 instead of NULL.  [readability/null] [5]
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/UIProcess/API/gtk/webkit2.h"
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Martin Robinson]

Comment on attachment 115146 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115146&action=review

>> Source/WebKit2/UIProcess/API/gtk/WebKitNetworkRequest.cpp:92
>> +                                                        NULL,
> 
> Use 0 instead of NULL.  [readability/null] [5]

Please fix.

[Carlos Garcia Campos]

Committed r100414: <http://trac.webkit.org/changeset/100414>