Bug 72349 - VCSUtils.pm doesn't handle svn 1.7 correctly
Summary: VCSUtils.pm doesn't handle svn 1.7 correctly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peter Kasting
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-14 20:19 PST by Peter Kasting
Modified: 2011-11-15 08:38 PST (History)
3 users (show)

See Also:


Attachments
patch v1 (1.00 KB, patch)
2011-11-14 20:22 PST, Peter Kasting
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Kasting 2011-11-14 20:19:58 PST
$isSVNDirectory fails on svn 1.7 in non-root directories because svn 1.7 eliminates the .svn subdirectories everywhere but the root.

I'm going to fix this by blindly copying the git code, which instead shells out to git to do the work, and adapt it to use "svn info".
Comment 1 Peter Kasting 2011-11-14 20:22:21 PST
Created attachment 115089 [details]
patch v1

This seems to work on my machine (tested both positively and negatively).  Did not test on svn 1.6 or below.
Comment 2 Adam Roben (:aroben) 2011-11-15 06:33:14 PST
Comment on attachment 115089 [details]
patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=115089&action=review

> Tools/Scripts/VCSUtils.pm:252
> +    return system("cd $dir && svn info > " . File::Spec->devnull() . " 2>&1") == 0;

I wonder if this will cause problems for folks using native Win32 Perl?
Comment 3 Adam Roben (:aroben) 2011-11-15 06:33:43 PST
Simon, any idea if this will be a problem for Qt/Win?
Comment 4 Simon Hausmann 2011-11-15 07:12:24 PST
(In reply to comment #3)
> Simon, any idea if this will be a problem for Qt/Win?

Don't think so :)
Comment 5 WebKit Review Bot 2011-11-15 08:38:13 PST
Comment on attachment 115089 [details]
patch v1

Clearing flags on attachment: 115089

Committed r100286: <http://trac.webkit.org/changeset/100286>
Comment 6 WebKit Review Bot 2011-11-15 08:38:19 PST
All reviewed patches have been landed.  Closing bug.