RESOLVED FIXED 72341
JS DOM wrappers depend on destructor to deref impl RefPtrs 
https://bugs.webkit.org/show_bug.cgi?id=72341
Summary JS DOM wrappers depend on destructor to deref impl RefPtrs
Mark Hahnenberg
Reported 2011-11-14 17:51:40 PST
In the ongoing effort to switch over all descendants of JSCell to using finalizers rather than virtual destructors, we need to clear the impl RefPtrs in the JS DOM wrappers. The destructor for the RefPtr will still run due to the continued use of virtual destructors for now.
Attachments
Patch (3.89 KB, patch)
2011-11-14 18:03 PST, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch with default wrapperOwner removed (12.64 KB, patch)
2011-11-15 17:29 PST, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2011-11-14 18:03:44 PST
Created attachment 115077 [details] Patch
Geoffrey Garen
Comment 2 2011-11-15 15:03:28 PST
Comment on attachment 115077 [details] Patch r=me
Mark Hahnenberg
Comment 3 2011-11-15 17:29:26 PST
Created attachment 115286 [details] Patch with default wrapperOwner removed
WebKit Review Bot
Comment 4 2011-11-15 20:29:37 PST
Comment on attachment 115286 [details] Patch with default wrapperOwner removed Clearing flags on attachment: 115286 Committed r100398: <http://trac.webkit.org/changeset/100398>
WebKit Review Bot
Comment 5 2011-11-15 20:29:41 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.