Bug 72341 - JS DOM wrappers depend on destructor to deref impl RefPtrs
Summary: JS DOM wrappers depend on destructor to deref impl RefPtrs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-14 17:51 PST by Mark Hahnenberg
Modified: 2011-11-15 20:29 PST (History)
3 users (show)

See Also:

Attachments
Patch (3.89 KB, patch)
2011-11-14 18:03 PST, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Patch with default wrapperOwner removed (12.64 KB, patch)
2011-11-15 17:29 PST, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2011-11-14 17:51:40 PST 
In the ongoing effort to switch over all descendants of JSCell to using finalizers rather than virtual destructors, we need to clear the impl RefPtrs in the JS DOM wrappers.  The destructor for the RefPtr will still run due to the continued use of virtual destructors for now.
Comment 1 Mark Hahnenberg 2011-11-14 18:03:44 PST 
Created attachment 115077 [details]
Patch
Comment 2 Geoffrey Garen 2011-11-15 15:03:28 PST 
Comment on attachment 115077 [details]
Patch

r=me
Comment 3 Mark Hahnenberg 2011-11-15 17:29:26 PST 
Created attachment 115286 [details]
Patch with default wrapperOwner removed
Comment 4 WebKit Review Bot 2011-11-15 20:29:37 PST 
Comment on attachment 115286 [details]
Patch with default wrapperOwner removed

Clearing flags on attachment: 115286

Committed r100398: <http://trac.webkit.org/changeset/100398>
Comment 5 WebKit Review Bot 2011-11-15 20:29:41 PST 
All reviewed patches have been landed.  Closing bug.