RESOLVED FIXED72337
De-virtualize ExecutableBase::clearCodeVirtual 
https://bugs.webkit.org/show_bug.cgi?id=72337
Summary De-virtualize ExecutableBase::clearCodeVirtual
Mark Hahnenberg
Reported 2011-11-14 17:25:57 PST
We can give explicit finalizers to all of the Executable classes that call static versions of clearCode. That is effectively the behavior already, although we do it with a virtual call rather than having a unique finalize method for each subclass.
Attachments
Patch (10.02 KB, patch)
2011-11-15 16:00 PST, Mark Hahnenberg 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2011-11-15 16:00:04 PST
Created attachment 115268 [details] Patch
Darin Adler
Comment 2 2011-11-15 16:04:25 PST
Comment on attachment 115268 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115268&action=review > Source/JavaScriptCore/runtime/Executable.cpp:90 > + NativeExecutable* thisObject = jsCast<NativeExecutable*>(cell); > + thisObject->clearCode(); Not sure the local variable adds much.
Mark Hahnenberg
Comment 3 2011-11-16 12:50:44 PST
Committed r100493: <http://trac.webkit.org/changeset/100493>
Note You need to log in before you can comment on or make changes to this bug.