Bug 72324 - DFG put_by_id transition optimizations test the wrong structures
Summary: DFG put_by_id transition optimizations test the wrong structures
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-11-14 16:03 PST by Filip Pizlo
Modified: 2011-11-14 17:06 PST (History)
0 users

See Also:

Attachments
the patch (4.09 KB, patch)
2011-11-14 16:08 PST, Filip Pizlo 		barraclough: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2011-11-14 16:03:55 PST 
Patch forthcoming
Comment 1 Filip Pizlo 2011-11-14 16:08:39 PST 
Created attachment 115053 [details]
the patch
Comment 2 Gavin Barraclough 2011-11-14 16:36:27 PST 
Comment on attachment 115053 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115053&action=review

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1825
> +                            if (previousStructure->storedPrototype().isCell())

I would prefer if the 'isCell' check check was a !isNull() check for consistency.
Comment 3 Filip Pizlo 2011-11-14 17:04:29 PST 
Landed in http://trac.webkit.org/changeset/100219
Comment 4 Filip Pizlo 2011-11-14 17:06:18 PST 
<rdar://problem/10445229>