Bug 72321 - Make ImageFrame member getAddr() public
Summary: Make ImageFrame member getAddr() public
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: noel gordon
URL:
Keywords:
Depends on:
Blocks: 59670
  Show dependency tree / graph
 
Reported: 2011-11-14 15:39 PST by noel gordon
Modified: 2011-11-15 01:36 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.20 KB, patch)
2011-11-14 15:41 PST, noel gordon 		no flags Details | Formatted Diff | Diff
Patch (2.62 KB, patch)
2011-11-14 18:15 PST, noel gordon 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description noel gordon 2011-11-14 15:39:46 PST 
Make ImageFrame member getAddr() public
Comment 1 noel gordon 2011-11-14 15:41:58 PST 
Created attachment 115046 [details]
Patch
Comment 2 Adam Barth 2011-11-14 17:24:00 PST 
Comment on attachment 115046 [details]
Patch

The ChangeLog needs to explain why we're making this change.
Comment 3 noel gordon 2011-11-14 17:26:57 PST 
Would something like https://bugs.webkit.org/show_bug.cgi?id=59670#c8 be enough?
Comment 4 Adam Barth 2011-11-14 17:31:06 PST 
Not really.  Sure, we could make the function public, but why would we want to?  As a general rule, we prefer to limit the visibility of functions.  Unless there's a reason to make it public, we'll probably leave it private.
Comment 5 noel gordon 2011-11-14 18:14:50 PST 
Ok, lemme better explain it then ...
Comment 6 noel gordon 2011-11-14 18:15:46 PST 
Created attachment 115079 [details]
Patch
Comment 7 Adam Barth 2011-11-14 18:16:55 PST 
Comment on attachment 115079 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115079&action=review

> Source/WebCore/ChangeLog:12
> +        Make ImageFrame member getAddr() public to allow ImageFrame users access to the
> +        underlying frame pixels if needed. Image decoders, for example, could with care
> +        use this service to write decoded pixels direct to the ImageFrame pixel buffer,
> +        avoiding intermeadiate data copies from temporary decoded pixel row buffers and
> +        the decoding performance loss that that entails.

Is there an example of an image decoder that would benefit from this API?
Comment 8 noel gordon 2011-11-14 18:18:49 PST 
> Is there an example of an image decoder that would benefit from this API?

libturbo-jpeg would be one example.
Comment 9 Adam Barth 2011-11-14 18:37:50 PST 
Comment on attachment 115079 [details]
Patch

Ok
Comment 10 WebKit Review Bot 2011-11-15 01:36:52 PST 
Comment on attachment 115079 [details]
Patch

Clearing flags on attachment: 115079

Committed r100252: <http://trac.webkit.org/changeset/100252>
Comment 11 WebKit Review Bot 2011-11-15 01:36:57 PST 
All reviewed patches have been landed.  Closing bug.