WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
72318
Test getting / setting display: -webkit-flexbox and -webkit-flexbox-inline
https://bugs.webkit.org/show_bug.cgi?id=72318
Summary
Test getting / setting display: -webkit-flexbox and -webkit-flexbox-inline
Julien Chaffraix
Reported
2011-11-14 15:19:49 PST
The fix for
bug 72296
did not see that -wap-marquee did impact querying back the display property for -webkit-flexbox and -webkit-flexbox-inline. This is because of the current code is using: template<> inline CSSPrimitiveValue::operator EDisplay() const { if (m_value.ident == CSSValueNone) return NONE; return static_cast<EDisplay>(m_value.ident - CSSValueInline); } Because of -wap-marquee, m_value.ident would be one off for any display property after it! Patch forthcoming to add the missing testing.
Attachments
Proposed test.
(4.37 KB, patch)
2011-11-14 15:21 PST
,
Julien Chaffraix
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Julien Chaffraix
Comment 1
2011-11-14 15:21:54 PST
Created
attachment 115044
[details]
Proposed test.
WebKit Review Bot
Comment 2
2011-11-14 16:20:31 PST
Comment on
attachment 115044
[details]
Proposed test. Clearing flags on attachment: 115044 Committed
r100211
: <
http://trac.webkit.org/changeset/100211
>
WebKit Review Bot
Comment 3
2011-11-14 16:20:36 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug