Bug 72318 - Test getting / setting display: -webkit-flexbox and -webkit-flexbox-inline
Summary: Test getting / setting display: -webkit-flexbox and -webkit-flexbox-inline
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-14 15:19 PST by Julien Chaffraix
Modified: 2011-11-14 16:20 PST (History)
3 users (show)

See Also:

Attachments
Proposed test. (4.37 KB, patch)
2011-11-14 15:21 PST, Julien Chaffraix 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2011-11-14 15:19:49 PST 
The fix for bug 72296 did not see that -wap-marquee did impact querying back the display property for -webkit-flexbox and -webkit-flexbox-inline. This is because of the current code is using:

template<> inline CSSPrimitiveValue::operator EDisplay() const
{
    if (m_value.ident == CSSValueNone)
        return NONE;
    return static_cast<EDisplay>(m_value.ident - CSSValueInline);
}

Because of -wap-marquee, m_value.ident would be one off for any display property after it!

Patch forthcoming to add the missing testing.
Comment 1 Julien Chaffraix 2011-11-14 15:21:54 PST 
Created attachment 115044 [details]
Proposed test.
Comment 2 WebKit Review Bot 2011-11-14 16:20:31 PST 
Comment on attachment 115044 [details]
Proposed test.

Clearing flags on attachment: 115044

Committed r100211: <http://trac.webkit.org/changeset/100211>
Comment 3 WebKit Review Bot 2011-11-14 16:20:36 PST 
All reviewed patches have been landed.  Closing bug.