Bug 72315 - Mouse Lock: Renaming to 'Pointer Lock': MouseLockable to PointerLock
Summary: Mouse Lock: Renaming to 'Pointer Lock': MouseLockable to PointerLock
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Vincent Scheib
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-14 14:59 PST by Vincent Scheib
Modified: 2011-11-15 14:39 PST (History)
6 users (show)

See Also:

Attachments
Patch (17.92 KB, patch)
2011-11-14 14:59 PST, Vincent Scheib 		no flags Details | Formatted Diff | Diff
Patch (18.01 KB, patch)
2011-11-14 15:08 PST, Vincent Scheib 		no flags Details | Formatted Diff | Diff
Patch (18.01 KB, patch)
2011-11-14 16:30 PST, Vincent Scheib 		no flags Details | Formatted Diff | Diff
Patch (17.92 KB, patch)
2011-11-15 11:10 PST, Vincent Scheib 		no flags Details | Formatted Diff | Diff
Patch for landing (17.92 KB, patch)
2011-11-15 13:28 PST, Vincent Scheib 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Scheib 2011-11-14 14:59:08 PST 
Mouse Lock: Renaming to 'Pointer Lock': MouseLockable to PointerLock
Comment 1 Vincent Scheib 2011-11-14 14:59:45 PST 
Created attachment 115036 [details]
Patch
Comment 2 Vincent Scheib 2011-11-14 15:06:09 PST 
Comment on attachment 115036 [details]
Patch

-- oops, forgot to edit the [Conditional...] new patch coming shortly...
Comment 3 Vincent Scheib 2011-11-14 15:08:24 PST 
Created attachment 115038 [details]
Patch
Comment 4 Dimitri Glazkov (Google) 2011-11-14 15:23:46 PST 
Comment on attachment 115038 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115038&action=review

> Source/WebCore/page/Navigator.idl:47
> +        readonly attribute [Conditional=POINTER_LOCK,EnabledAtRuntime] PointerLock webkitPointer;

space after comma?
Comment 5 Gustavo Noronha (kov) 2011-11-14 15:36:51 PST 
Comment on attachment 115038 [details]
Patch

Attachment 115038 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10483071
Comment 6 Vincent Scheib 2011-11-14 16:29:33 PST 
Addressing Dimitri's space nit.
Also, rekicking gtk EWS, seems to be an unrelated error?
Comment 7 Vincent Scheib 2011-11-14 16:30:11 PST 
Created attachment 115054 [details]
Patch
Comment 8 Gustavo Noronha (kov) 2011-11-14 17:35:35 PST 
Comment on attachment 115054 [details]
Patch

Attachment 115054 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10484117
Comment 9 Vincent Scheib 2011-11-15 11:10:18 PST 
Created attachment 115205 [details]
Patch
Comment 10 Vincent Scheib 2011-11-15 11:12:00 PST 
GTK was still failing? Not certain what the issue is. Attempting with Navigator.idl no using [Conditional] on the attribute?
Comment 11 Vincent Scheib 2011-11-15 11:35:54 PST 
Comment on attachment 115205 [details]
Patch

GTK was failing. I changed Navigator.idl to not use the [Conditional] prefix on the attribute, instead wrapping with "#if defined(ENABLE_POINTER_LOCK) ..." and the bot passes OK.
Comment 12 Vincent Scheib 2011-11-15 13:28:29 PST 
Created attachment 115229 [details]
Patch for landing
Comment 13 WebKit Review Bot 2011-11-15 14:39:10 PST 
Comment on attachment 115229 [details]
Patch for landing

Clearing flags on attachment: 115229

Committed r100328: <http://trac.webkit.org/changeset/100328>
Comment 14 WebKit Review Bot 2011-11-15 14:39:17 PST 
All reviewed patches have been landed.  Closing bug.