RESOLVED INVALID 72298
Use Region::contains() when to decide if GraphicsLayer is opaque 
https://bugs.webkit.org/show_bug.cgi?id=72298
Summary Use Region::contains() when to decide if GraphicsLayer is opaque
Dana Jansens
Reported 2011-11-14 12:51:36 PST
Consider the union of the opaque regions of each RenderLayer in a backing when determining if the backing is opaque.
Attachments
Patch (6.92 KB, patch)
2011-11-14 13:25 PST, Dana Jansens 		no flags
DetailsFormatted DiffDiff
update for Region::contains() (51.88 KB, patch)
2011-11-18 09:06 PST, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ec2-cr-linux-03 (173.15 KB, application/zip)
2011-11-18 09:38 PST, WebKit Review Bot 		no flags
Details
Patch (7.87 KB, patch)
2011-11-18 10:14 PST, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Patch (982 bytes, patch)
2011-11-23 13:21 PST, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Dana Jansens
Comment 1 2011-11-14 12:54:15 PST
Make use of the Region::occluded() test from bug #72294 to reach this intermediate step, where we consider all relevant RenderLayers for a backing together. Next step: For each RenderLayer, we need to consider more than a single RenderObject and construct an opaque Region for the layer.
Dana Jansens
Comment 2 2011-11-14 13:25:29 PST
Created attachment 115020 [details] Patch
Dana Jansens
Comment 3 2011-11-18 09:06:46 PST
Created attachment 115822 [details] update for Region::contains()
WebKit Review Bot
Comment 4 2011-11-18 09:38:00 PST
Comment on attachment 115822 [details] update for Region::contains() Attachment 115822 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10374629 New failing tests: compositing/geometry/limit-layer-bounds-transformed.html compositing/iframes/enter-compositing-iframe.html compositing/iframes/connect-compositing-iframe.html compositing/geometry/clip.html compositing/geometry/fixed-position-composited-switch.html compositing/geometry/limit-layer-bounds-fixed-positioned.html compositing/geometry/limit-layer-bounds-positioned.html compositing/layer-creation/overlap-child-layer.html compositing/geometry/limit-layer-bounds-transformed-overflow.html compositing/geometry/limit-layer-bounds-positioned-transition.html compositing/layer-creation/overlap-transformed-layer.html compositing/layer-creation/translatez-overlap.html compositing/iframes/become-composited-nested-iframes.html compositing/geometry/limit-layer-bounds-overflow-root.html compositing/layer-creation/spanOverlapsCanvas.html compositing/geometry/limit-layer-bounds-clipping-ancestor.html compositing/layer-creation/overlap-clipping.html compositing/geometry/layer-due-to-layer-children-deep-switch.html compositing/iframes/connect-compositing-iframe-delayed.html compositing/layer-creation/overflow-scroll-overlap.html
WebKit Review Bot
Comment 5 2011-11-18 09:38:04 PST
Created attachment 115824 [details] Archive of layout-test-results from ec2-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-03 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Dana Jansens
Comment 6 2011-11-18 10:14:32 PST
Created attachment 115827 [details] Patch
Dana Jansens
Comment 7 2011-11-23 13:21:35 PST
Created attachment 116407 [details] Patch
Dana Jansens
Comment 8 2011-12-09 13:27:44 PST
Dropping this as bug #71972 will likely not happen, opting for more simple approach.
Note You need to log in before you can comment on or make changes to this bug.