Bug 72293 - [Chromium] build-webkit silently drops the features flags
Summary: [Chromium] build-webkit silently drops the features flags
Status: RESOLVED DUPLICATE of bug 72629
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified All
: P2 Normal
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-14 11:29 PST by Julien Chaffraix
Modified: 2011-11-17 10:31 PST (History)
4 users (show)

See Also:


Attachments
Proposed fix: add a warning (1.90 KB, patch)
2011-11-14 11:34 PST, Julien Chaffraix
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2011-11-14 11:29:58 PST
Currently build-webkit on Chromium does nothing with the @features variable but does not notify anyone! For the casual developer, it looks like everything is working, until the feature is not compiled in.

Per discussion, fixing that is difficult without slowing down everybody's workflow so let's add a warning about that.

Patch forthcoming.
Comment 1 Julien Chaffraix 2011-11-14 11:34:58 PST
Created attachment 114994 [details]
Proposed fix: add a warning
Comment 2 Tony Chang 2011-11-14 11:40:21 PST
Comment on attachment 114994 [details]
Proposed fix: add a warning

Thanks!
Comment 3 Julien Chaffraix 2011-11-14 12:53:09 PST
Comment on attachment 114994 [details]
Proposed fix: add a warning

Thanks for writing the wiki Tony!
Comment 4 WebKit Review Bot 2011-11-14 13:46:09 PST
Comment on attachment 114994 [details]
Proposed fix: add a warning

Clearing flags on attachment: 114994

Committed r100184: <http://trac.webkit.org/changeset/100184>
Comment 5 WebKit Review Bot 2011-11-14 13:46:13 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Adam Barth 2011-11-16 21:43:26 PST
I get this message every time I build.  I don't think I have any non-default features.  Any idea what's wrong?
Comment 7 Tony Chang 2011-11-17 09:46:30 PST
(In reply to comment #6)
> I get this message every time I build.  I don't think I have any non-default features.  Any idea what's wrong?

I saw it on the bots too.  I think it might be confused by --chromium?  I'll take a look.
Comment 8 Julien Chaffraix 2011-11-17 09:54:34 PST
(In reply to comment #7)
> (In reply to comment #6)
> > I get this message every time I build.  I don't think I have any non-default features.  Any idea what's wrong?
> 
> I saw it on the bots too.  I think it might be confused by --chromium?  I'll take a look.

I don't think it is the --chromium as this should be the trigger for the behavior. I have seen the error for --debug but not for --release (or the other way around I can't recall) so I would look into those 2 first. I could investigate if you prefer!
Comment 9 Tony Chang 2011-11-17 09:59:03 PST
https://bugs.webkit.org/show_bug.cgi?id=72629
Comment 10 Adam Barth 2011-11-17 10:31:50 PST

*** This bug has been marked as a duplicate of bug 72629 ***