RESOLVED FIXED72276
Web Inspector: Command line $x fails for 3 of 4 types of XPath query 
https://bugs.webkit.org/show_bug.cgi?id=72276
Summary Web Inspector: Command line $x fails for 3 of 4 types of XPath query
Pavel Feldman
Reported 2011-11-14 08:31:10 PST
(Upstream from http://code.google.com/p/chromium/issues/detail?id=97528). Although we don't have to do that by the spec, it is a handy improvement.
Attachments
Patch (4.64 KB, patch)
2011-11-14 10:03 PST, Pavel Feldman 		timothy: review+
timothy: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-11-14 10:03:05 PST
Created attachment 114973 [details] Patch
Timothy Hatcher
Comment 2 2011-11-14 13:45:02 PST
Comment on attachment 114973 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114973&action=review r+ is you land it with the style fixed. > Source/WebCore/inspector/InjectedScriptSource.js:600 > + case XPathResult.NUMBER_TYPE: return result.numberValue; > + case XPathResult.STRING_TYPE: return result.stringValue; > + case XPathResult.BOOLEAN_TYPE: return result.booleanValue; The case and the return should be on seperate lines.
Pavel Feldman
Comment 3 2011-11-14 23:50:29 PST
(In reply to comment #2) > (From update of attachment 114973 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=114973&action=review > > r+ is you land it with the style fixed. > > > Source/WebCore/inspector/InjectedScriptSource.js:600 > > + case XPathResult.NUMBER_TYPE: return result.numberValue; > > + case XPathResult.STRING_TYPE: return result.stringValue; > > + case XPathResult.BOOLEAN_TYPE: return result.booleanValue; > > The case and the return should be on seperate lines. Welcome back :)
Pavel Feldman
Comment 4 2011-11-15 00:09:16 PST
Committed r100246: <http://trac.webkit.org/changeset/100246>
Note You need to log in before you can comment on or make changes to this bug.