Bug 72268 - Web Inspector: expose iframe window to the onShown event handler of panels & sidebars
Summary: Web Inspector: expose iframe window to the onShown event handler of panels & ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-14 06:30 PST by Andrey Kosyakov
Modified: 2011-11-14 08:30 PST (History)
10 users (show)

See Also:

Attachments
Patch (24.97 KB, patch)
2011-11-14 06:32 PST, Andrey Kosyakov 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2011-11-14 06:30:04 PST 
- replace IFrameView with ExtensionView
- inherit both ExtensionPanel and ExtensionSidebarPane from ExtensionView in the API
- move Panel.{onShow|onHide} to ExtensionView, effectively disabling show/hide notifications for non-extension panels and enabling it for sidebar panes
- expose iframe's window object in the onShow event handler
Comment 1 Andrey Kosyakov 2011-11-14 06:32:12 PST 
Created attachment 114935 [details]
Patch
Comment 2 Andrey Kosyakov 2011-11-14 08:30:00 PST 
Committed r100145: <http://trac.webkit.org/changeset/100145>